From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751920AbbJXOHe (ORCPT <rfc822;w@1wt.eu>);
	Sat, 24 Oct 2015 10:07:34 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:43254 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751253AbbJXOHc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 24 Oct 2015 10:07:32 -0400
Date: Sat, 24 Oct 2015 07:24:05 -0700 (PDT)
Message-Id: <20151024.072405.1054520777247556344.davem@davemloft.net>
To: mans@mansr.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: ethernet: add driver for Aurora VLSI
 NB8800 Ethernet controller
From: David Miller <davem@davemloft.net>
In-Reply-To: <1445531330-17461-2-git-send-email-mans@mansr.com>
References: <1445531330-17461-1-git-send-email-mans@mansr.com>
	<1445531330-17461-2-git-send-email-mans@mansr.com>
X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 24 Oct 2015 07:07:32 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Mans Rullgard <mans@mansr.com>
Date: Thu, 22 Oct 2015 17:28:50 +0100

> +static void nb8800_mac_tx(struct net_device *dev, int enable)
 ...
> +static void nb8800_mac_rx(struct net_device *dev, int enable)
 ...
> +static void nb8800_mac_af(struct net_device *dev, int enable)

Please use 'bool' and true/false for 'enable'.

> +static int nb8800_alloc_rx(struct net_device *dev, int i, int napi)

Likewise here for 'napi'.