Re: [PATCH v4 4/4] ARM: dts: sun6i: Add dts file for MSI Primo81 tablet

[Karsten Merker <merker@debian.org>]

On Sat, Oct 24, 2015 at 11:15:51AM +0800, Chen-Yu Tsai wrote:
> On Sat, Oct 24, 2015 at 12:56 AM, Karsten Merker <merker@debian.org> wrote:
> > On Fri, Oct 23, 2015 at 11:56:35PM +0800, Chen-Yu Tsai wrote:
> >> On Fri, Oct 23, 2015 at 11:46 PM, Chen-Yu Tsai <wens@csie.org> wrote:
> >> > On Fri, Oct 23, 2015 at 10:53 PM, Karsten Merker <merker@debian.org> wrote:
> >> >> On Fri, Oct 23, 2015 at 11:50:41AM +0800, Chen-Yu Tsai wrote:
> > [...]
> >> >>> +/ {
> >> >>> +     model = "MSI Primo81 tablet";
> >> >>> +     compatible = "msi,primo81", "allwinner,sun6i-a31s";
> >> >>> +};
> > [...]
> >> >>> +&i2c1 {
> >> >>> +     pinctrl-names = "default";
> >> >>> +     pinctrl-0 = <&i2c1_pins_a>;
> >> >>> +     status = "okay";
> >> >>> +
> >> >>> +     ctp@5d {
> >> >>> +             pinctrl-names = "default";
> >> >>> +             pinctrl-0 = <&gt911_int_primo81>;
> >> >>> +             compatible = "goodix,gt911";
> >> >>> +             reg = <0x5d>;
> >> >>> +             interrupt-parent = <&pio>;
> >> >>> +             interrupts = <0 3 IRQ_TYPE_LEVEL_HIGH>; /* PA3 */
> >> >>
> >> >> I'd like to add a
> >> >>
> >> >>                 touchscreen-swapped-x-y = "true";
> >> >>
> >> >> as described in
> >> >> Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
> >> >> here, as the display is in portrait mode while the touchscreen is
> >> >> in landscape mode and needs to have the x and y axes swapped to
> >> >> work in the same coordinate system as the display.
> >> >>
> >> >> Regarding the driver side: the goodix driver in kernel 4.3
> >> >> doesn't yet support this property, but patches to add support for
> >> >> it are on the linux-input list and should hopefully make it into
> >> >> kernel 4.4.
> >> >
> >> > The DTS is already in Maxime's tree, and in sunxi-next. Feel free to
> >> > send a follow-up patch adding them. I was waiting for those patches
> >> > to be merged.
> >>
> >> Sorry, spoke too soon. Maxime hasn't pushed it out yet. Could you send
> >> a patch adding touchscreen-swapped-x-y for Maxime to squash in?
> >
> > I'm happy to do so, but I have just stumbled over a problem with
> > actually building the dtb for testing - it fails with
> >
> >   arch/arm/boot/dts/sun6i-a31s-primo81.dts:242.1-14 Label or path simplefb_lcd not found
> >
> > The dts references simplefb_lcd:
> >
> > +&simplefb_lcd {
> > +       vcc-lcd-supply = <&reg_dc1sw>;
> > +       vdd-mipi-bridge-supply = <&reg_eldo3>;
> > +};
> >
> > but I don't see where it would be defined. This is on the current
> > sunxi/for-next branch of
> > https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git
> > with the Primo81 dts patch on top. Am I perhaps missing some
> > required additional patch here?
> 
> Yes. The previous patch that adds labels to the simplefb nodes.

Thanks for the info, that one doesn't seem to have landed in
my inbox.

> Both patches are now in sunxi/for-next in Maxime's tree now.

I've pulled them in the meantime and will post a follow-up patch
immediately.

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.