From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbbJYI3I (ORCPT ); Sun, 25 Oct 2015 04:29:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33684 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbbJYI3D (ORCPT ); Sun, 25 Oct 2015 04:29:03 -0400 Date: Sat, 24 Oct 2015 18:59:51 -0700 From: Greg Kroah-Hartman To: Muhammad Falak R Wani Cc: Mike Marciniszyn , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: rdma: ipath: Use setup_timer Message-ID: <20151025015951.GB30763@kroah.com> References: <1445653168-2883-1-git-send-email-falakreyaz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445653168-2883-1-git-send-email-falakreyaz@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 24, 2015 at 07:49:28AM +0530, Muhammad Falak R Wani wrote: > Use the timer API function setup_timer instead of init_timer, removing > the structure field assignments. > > > > @timer@ > expression e1,e2,e3,fn_ptr; > @@ > -init_timer(&e1); > +setup_timer(&e1, fn_ptr, e2); > ... when != fn_ptr = e3 > -e1.function = fn_ptr; > -e1.data = e2; > > > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/staging/rdma/ipath/ipath_driver.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) You sent me 4 patches all with the same subject :( Please fix this up and resend. thanks, greg k-h