From: saurabh <saurabh.truth@gmail.com>
To: gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
balbi@ti.com, chasemetzger15@gmail.com,
rafael.j.wysocki@intel.com, mjg59@coreos.com,
Robert.Schlabbach@gmx.net, jwerner@chromium.org,
jin.can.zhuang@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, celinux-dev@tree.celinuxforum.org
Cc: saurabh.truth@gmail.com
Subject: [PATCH] fixing the coding style changes
Date: Sun, 25 Oct 2015 12:17:11 +0530 [thread overview]
Message-ID: <20151025064711.GA5729@localhost.localdomain> (raw)
>From 999005638f8d3f95075fdfdc6bf8f7ff88810f5d Mon Sep 17 00:00:00 2001
From: Saurabh Sengar <saurabh.truth@gmail.com>
Date: Sun, 25 Oct 2015 08:58:42 +0530
Subject: [PATCH] fixing the coding style changes
Attached a patch whic fixes the checkpatch.pl script error
Here, couple of static variables were initialise to 0 which
was violating the linux coding style standards.
diffstat for this patch is:
hub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
To apply the patch, in the root of a kernel tree use:
patch -p1 < 0001-fixing-the-coding-style-changes.patch
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
drivers/usb/core/hub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 431839b..6abc4ab 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -49,7 +49,7 @@ static void hub_event(struct work_struct *work);
DEFINE_MUTEX(usb_port_peer_mutex);
/* cycle leds on hubs that aren't blinking for attention */
-static bool blinkenlights = 0;
+static bool blinkenlights;
module_param(blinkenlights, bool, S_IRUGO);
MODULE_PARM_DESC(blinkenlights, "true to cycle leds on hubs");
@@ -78,7 +78,7 @@ MODULE_PARM_DESC(initial_descriptor_timeout,
* otherwise the new scheme is used. If that fails and "use_both_schemes"
* is set, then the driver will make another attempt, using the other scheme.
*/
-static bool old_scheme_first = 0;
+static bool old_scheme_first;
module_param(old_scheme_first, bool, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(old_scheme_first,
"start with the old device initialization scheme");
--
1.9.1
next reply other threads:[~2015-10-25 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 6:47 saurabh [this message]
2015-10-25 8:26 ` Greg KH
2015-10-25 19:19 ` Albino B Neto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151025064711.GA5729@localhost.localdomain \
--to=saurabh.truth@gmail.com \
--cc=Robert.Schlabbach@gmx.net \
--cc=balbi@ti.com \
--cc=celinux-dev@tree.celinuxforum.org \
--cc=chasemetzger15@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jin.can.zhuang@intel.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mjg59@coreos.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome