From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753060AbbJYKJQ (ORCPT ); Sun, 25 Oct 2015 06:09:16 -0400 Received: from casper.infradead.org ([85.118.1.10]:56857 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbbJYKJP (ORCPT ); Sun, 25 Oct 2015 06:09:15 -0400 Date: Sun, 25 Oct 2015 11:09:24 +0100 From: Peter Zijlstra To: Olav Haugan Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] sched: Update task->on_rq when tasks are moving between runqueues Message-ID: <20151025100924.GP2508@worktop.programming.kicks-ass.net> References: <1445709662-17232-1-git-send-email-ohaugan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445709662-17232-1-git-send-email-ohaugan@codeaurora.org> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 24, 2015 at 11:01:02AM -0700, Olav Haugan wrote: > Task->on_rq has three states: > 0 - Task is not on runqueue (rq) > 1 (TASK_ON_RQ_QUEUED) - Task is on rq > 2 (TASK_ON_RQ_MIGRATING) - Task is on rq but in the process of being > migrated to another rq > > When a task is moving between rqs task->on_rq state should be > TASK_ON_RQ_MIGRATING Only when not holding both rq locks..