From: Borislav Petkov <bp@suse.de>
To: "Huang, Ying" <ying.huang@linux.intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
"Huang, Ying" <ying.huang@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] GHES: Fix cached error-status
Date: Mon, 26 Oct 2015 05:30:21 +0100 [thread overview]
Message-ID: <20151026043021.GA9328@nazgul.tnic> (raw)
In-Reply-To: <87611uz56k.fsf@yhuang-dev.intel.com>
On Mon, Oct 26, 2015 at 11:20:35AM +0800, Huang, Ying wrote:
> In ghes_estatus_caches[], for caches with same contents, the cache with
> biggest (newest) cache->time_in should be the first. So if we found one
> cache with too small (old) cache->time_in, we can say there are no cache
> with same contents and bigger (newer) cache->time_in, so that we can
> make decision (break) earlier.
Well, for starters, this should be documented in the code so that people
looking at it would not need to scratch their heads over that break
statement there.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2015-10-26 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 17:55 Davidlohr Bueso
2015-10-23 22:50 ` Davidlohr Bueso
2015-10-23 23:05 ` Luck, Tony
2015-10-26 3:20 ` Huang, Ying
2015-10-26 4:30 ` Borislav Petkov [this message]
2015-10-26 5:43 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026043021.GA9328@nazgul.tnic \
--to=bp@suse.de \
--cc=dave@stgolabs.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
--cc=ying.huang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome