From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714AbbJZRpq (ORCPT ); Mon, 26 Oct 2015 13:45:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56530 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbbJZRpp (ORCPT ); Mon, 26 Oct 2015 13:45:45 -0400 Date: Mon, 26 Oct 2015 18:45:42 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , "Liang, Kan" Subject: Re: [PATCH 03/52] perf tools: Add thread_map event Message-ID: <20151026174542.GA6567@krava.brq.redhat.com> References: <1445784728-21732-1-git-send-email-jolsa@kernel.org> <1445784728-21732-4-git-send-email-jolsa@kernel.org> <20151026174206.GN27006@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151026174206.GN27006@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2015 at 02:42:06PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > PERF_RECORD_AUXTRACE_ERROR = 72, > > + PERF_RECORD_THREAD_MAP = 73, > > PERF_RECORD_HEADER_MAX > > }; > > > > @@ -356,6 +357,17 @@ struct context_switch_event { > > u32 next_prev_tid; > > }; > > > > +struct thread_map_data_event { > > Humm, I think "data" here is way too vague here, how about > "thread_map_event_entry"? > > Moving of "entry" to the end also helps in understanding that this is > not an "event" per se, it doesn't have the perv_event_header, etc, its > just an entry in a 'struct thread_map_event'. > > I'm tentatively doing this change in my local branch, please let me know > if you have any reason to object to such a change, np, hope there's not much dependency on this later in patchset ;-) probably not.. thanks, jirka