From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755191AbbJ1CaY (ORCPT ); Tue, 27 Oct 2015 22:30:24 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44624 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754729AbbJ1CaX (ORCPT ); Tue, 27 Oct 2015 22:30:23 -0400 Date: Tue, 27 Oct 2015 19:47:04 -0700 (PDT) Message-Id: <20151027.194704.863557122432415853.davem@davemloft.net> To: sowmini.varadhan@oracle.com Cc: rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, santosh.shilimkar@oracle.com Subject: Re: [PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv From: David Miller In-Reply-To: <20151026164637.GK10039@oracle.com> References: <20151026164637.GK10039@oracle.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 27 Oct 2015 19:30:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sowmini Varadhan Date: Mon, 26 Oct 2015 12:46:37 -0400 > Either of pskb_pull() or pskb_trim() may fail under low memory conditions. > If rds_tcp_data_recv() ignores such failures, the application will > receive corrupted data because the skb has not been correctly > carved to the RDS datagram size. > > Avoid this by handling pskb_pull/pskb_trim failure in the same > manner as the skb_clone failure: bail out of rds_tcp_data_recv(), and > retry via the deferred call to rds_send_worker() that gets set up on > ENOMEM from rds_tcp_read_sock() > > Signed-off-by: Sowmini Varadhan Applied and queued up for -stable, thanks.