From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbbJ0BJo (ORCPT ); Mon, 26 Oct 2015 21:09:44 -0400 Received: from mail.skyhub.de ([78.46.96.112]:43049 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbbJ0BJm (ORCPT ); Mon, 26 Oct 2015 21:09:42 -0400 Date: Tue, 27 Oct 2015 02:09:37 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tony.luck@intel.com, x86@kernel.org, ashok.raj@intel.com, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, peterz@infradead.org, luto@kernel.org, dvlasenk@redhat.com, ross.zwisler@linux.intel.com, dirk.j.brandewie@intel.com, Wan Zongshun Subject: Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature Message-ID: <20151027010937.GA2982@nazgul.tnic> References: <1445599113-8792-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1445599113-8792-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <20151025103703.GB6084@nazgul.tnic> <562E42FB.6030600@amd.com> <20151026202250.GD11980@nazgul.tnic> <562EAE47.2080100@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <562EAE47.2080100@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2015 at 05:50:47PM -0500, Aravind Gopalakrishnan wrote: > How do you prefer a V2 for this to be sent though- > Shall I wait until your fixes are in tip.git and resend? > Or send a V2 on top of current tip.git? Actually, I just showed it to hpa and he says those CPUID leafs are going to be filled at some point so no need to add them to the scattered features list. If that AMD CPUID leaf 0x80000008 is going to be containing more CPUID feature bits - and it sounded like it will because you called it "AMD extended features 2" - then those should really go into into the x86_capability array, i.e., like you've done it in your initial version. This also means, that the scattered features would need to get stuff moved over to the x86_capability array too, but that's for later. So please fix the SOB chain of your initial patch and send that one out. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --