From: Vinod Koul <vinod.koul@intel.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA
Date: Tue, 27 Oct 2015 11:10:09 +0900 [thread overview]
Message-ID: <20151027021008.GD11691@vkoul-mobl.iind.intel.com> (raw)
In-Reply-To: <1444980919-20331-3-git-send-email-jonathanh@nvidia.com>
On Fri, Oct 16, 2015 at 08:35:19AM +0100, Jon Hunter wrote:
> +static inline void tdma_ch_write(struct tegra_adma_chan *tdc,
> + u32 reg, u32 val)
Coding style issue here
> +static int tegra_adma_alloc_chan_resources(struct dma_chan *dc)
> +{
> + struct tegra_adma_chan *tdc = to_tegra_adma_chan(dc);
> + int ret;
> +
> + ret = pm_runtime_get_sync(tdc2dev(tdc));
> + if (ret)
> + return ret;
pm_runtime_get_sync() return postive values on success too, so this can
fail. This check should be for less than zero case
--
~Vinod
next prev parent reply other threads:[~2015-10-27 2:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 7:35 [PATCH V3 0/2] " Jon Hunter
2015-10-16 7:35 ` [PATCH V3 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter
2015-10-16 16:09 ` Stephen Warren
2015-10-19 11:22 ` Jon Hunter
2015-10-19 16:33 ` Stephen Warren
2015-10-20 8:54 ` Jon Hunter
2015-10-16 7:35 ` [PATCH V3 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA Jon Hunter
2015-10-27 2:10 ` Vinod Koul [this message]
2015-10-27 9:24 ` Jon Hunter
2015-10-28 13:17 ` Jon Hunter
2015-10-29 21:03 ` Andy Shevchenko
2015-11-02 16:22 ` Jon Hunter
2015-11-03 11:06 ` Jon Hunter
2016-05-20 18:51 ` [PATCH V3 0/2] " Paul Gortmaker
2016-05-24 3:53 ` Vinod Koul
2016-05-24 11:19 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027021008.GD11691@vkoul-mobl.iind.intel.com \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®