From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932075AbbJ0DW7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 26 Oct 2015 23:22:59 -0400
Received: from mail.skyhub.de ([78.46.96.112]:34094 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753715AbbJ0DW5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 26 Oct 2015 23:22:57 -0400
Date: Tue, 27 Oct 2015 04:22:43 +0100
From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
        Tony Luck <tony.luck@intel.com>, X86 ML <x86@kernel.org>,
        ashok.raj@intel.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-edac <linux-edac@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Ross Zwisler <ross.zwisler@linux.intel.com>,
        Dirk Brandewie <dirk.j.brandewie@intel.com>,
        Wan Zongshun <Vincent.Wan@amd.com>
Subject: Re: [RFC PATCH] x86/cpu: Move sparsely used bit leafs into scattered
 features (was: Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature)
Message-ID: <20151027032243.GB3946@nazgul.tnic>
References: <1445599113-8792-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
 <1445599113-8792-3-git-send-email-Aravind.Gopalakrishnan@amd.com>
 <20151025103703.GB6084@nazgul.tnic>
 <562E42FB.6030600@amd.com>
 <20151026202250.GD11980@nazgul.tnic>
 <20151026210132.GF11980@nazgul.tnic>
 <CALCETrX0D3pM29VCve68nvZNQEYNXNMp90HZes5CMoWWs0t7AA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALCETrX0D3pM29VCve68nvZNQEYNXNMp90HZes5CMoWWs0t7AA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 26, 2015 at 07:56:06PM -0700, Andy Lutomirski wrote:
> How few features in one leaf do we need before calling it scattered
> makes sense?  These four might make sense to keep as is...

Actually, according to hpa, all those leafs will be filled out gradually
as they're apparently going to be used for hw features. And it looks
like the AMD leaf is of the same type. So those all will be fleshed out
with time and we can keep them here, in cpufeature.h.

> ...whereas this looks totally reasonable.
> 
> FWIW, we have a ton of thses things.  Would it make sense to convert
> this to a text file giving features and their CPUID positions that
> generates the defines and the code to enumerate them?

Yeah, maybe. I'm not that really bothered by the current form too,
though.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--