From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965020AbbJ0RHT (ORCPT ); Tue, 27 Oct 2015 13:07:19 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:38044 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754187AbbJ0RHQ (ORCPT ); Tue, 27 Oct 2015 13:07:16 -0400 Date: Tue, 27 Oct 2015 12:59:32 -0400 From: Vivien Didelot To: Neil Armstrong Cc: Florian Fainelli , "David S. Miller" , Andrew Lunn , Guenter Roeck , Fabian Frederick , Pavel Nakonechny , Joe Perches , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Frode Isaksen Subject: Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources Message-ID: <20151027165932.GA21799@ketchup.mtl.sfl> References: <562F8ED7.2000804@baylibre.com> <562F9AAB.8090202@gmail.com> <562F9BB1.8090700@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <562F9BB1.8090700@baylibre.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct. Tuesday 27 (44) 04:43 PM, Neil Armstrong wrote: > Hi, > On 10/27/2015 04:39 PM, Florian Fainelli wrote: > > On 27/10/15 07:48, Neil Armstrong wrote: > >> Some switch drivers might request interrupts, remap register ranges, > >> allow such drivers to implement a "remove" callback doing just that. > >> > >> Suggested-by: Florian Fainelli > > > > This should probably be a Signed-off-by tag, but there is nothing using > > this, so you would want to introduce an user of this function in the > > same patch series so we see how you intend to use it? > > > >> Signed-off-by: Neil Armstrong > > Yes, I didn't know how to handle this since it was part of a larger patch. > > I forgot to add this into the cover-letter but I wanted to send an RFC serie with > your bcm remove patch and a mv88e6xxx remove experimental code. > > Yet, the mv88e6060 does not make usage of this. So this patch must be part of your RFC for module removal instead of this patchset. Thanks, -v