From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Wan, Kaike" <kaike.wan@intel.com>
Cc: "Weiny, Ira" <ira.weiny@intel.com>,
Saurabh Sengar <saurabh.truth@gmail.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
"hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
"yun.wang@profitbricks.com" <yun.wang@profitbricks.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC
Date: Tue, 27 Oct 2015 14:00:12 -0600 [thread overview]
Message-ID: <20151027200012.GA7403@obsidianresearch.com> (raw)
In-Reply-To: <3F128C9216C9B84BB6ED23EF16290AFB18571E3F@CRSMSX101.amr.corp.intel.com>
On Tue, Oct 27, 2015 at 06:56:50PM +0000, Wan, Kaike wrote:
> > I do wonder if it is a good idea to call ib_nl_send_msg with a spinlock held
> > though.. Would be nice to see that go away.
>
> We have to hold the lock to protect against a race condition that a
> quick response will try to free the request from the
> ib_nl_request_list before we even put it on the list.
Put is on the list first? Use a kref? Doesn't look like a big deal to
clean this up.
Jason
next prev parent reply other threads:[~2015-10-27 20:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 15:47 Saurabh Sengar
2015-10-27 18:12 ` ira.weiny
2015-10-27 18:16 ` Jason Gunthorpe
2015-10-27 18:20 ` ira.weiny
2015-10-27 18:56 ` Wan, Kaike
2015-10-27 20:00 ` Jason Gunthorpe [this message]
2015-10-28 4:30 ` Weiny, Ira
2015-11-13 7:42 ` Saurabh Sengar
2015-11-13 10:47 ` Wan, Kaike
2015-11-13 12:37 ` Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027200012.GA7403@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=ira.weiny@intel.com \
--cc=kaike.wan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=saurabh.truth@gmail.com \
--cc=sean.hefty@intel.com \
--cc=yun.wang@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome