From: Steven Rostedt <rostedt@goodmis.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Only benchmark the time tracepoints take if tracing is on
Date: Tue, 27 Oct 2015 22:28:16 -0400 [thread overview]
Message-ID: <20151027222816.32454410@grimm.local.home> (raw)
In-Reply-To: <1445947933-27955-1-git-send-email-zhang.chunyan@linaro.org>
On Tue, 27 Oct 2015 20:12:13 +0800
Chunyan Zhang <zhang.chunyan@linaro.org> wrote:
> There's no need to record the time tracepoints take when tracing is off.
> This is because:
> 1) We cannot see these records since ring_buffer record is off at that
> moment.
> 2) If tracing is off and benchmark tracepoint is enabled, the time
> tracepoint takes is fewer than the same situation when tracing is on,
> since the tracepoints need to be wrote into ring_buffer, it would
> take more time. If turn on tracing at this moment, the average and
> standard deviation cannot exactly present the time that tracepoints
> take to write data into ring_buffer.
>
Thanks! I'll add this when I get back from traveling.
-- Steve
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
prev parent reply other threads:[~2015-10-28 2:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 12:12 Chunyan Zhang
2015-10-28 2:28 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027222816.32454410@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®