From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754807AbbJ1BFR (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Oct 2015 21:05:17 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38246 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752161AbbJ1BFO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Oct 2015 21:05:14 -0400
Date: Wed, 28 Oct 2015 10:04:43 +0900
From: Mark Brown <broonie@kernel.org>
To: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: alsa-devel@alsa-project.org, James Hartley <James.Hartley@imgtec.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <20151028010443.GX28319@sirena.org.uk>
References: <1444653637-14711-1-git-send-email-Damien.Horsley@imgtec.com>
 <1444653637-14711-3-git-send-email-Damien.Horsley@imgtec.com>
 <20151019174732.GG32054@sirena.org.uk>
 <56293472.7000401@imgtec.com>
 <20151023225723.GO29919@sirena.org.uk>
 <562F824F.9070407@imgtec.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="E5HUUwS3R9LcK7+r"
Content-Disposition: inline
In-Reply-To: <562F824F.9070407@imgtec.com>
X-Cookie: "But I don't like Spam!!!!"
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 58.123.138.250
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S
 input controller
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--E5HUUwS3R9LcK7+r
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 27, 2015 at 01:55:27PM +0000, Damien Horsley wrote:
> On 23/10/15 23:57, Mark Brown wrote:

> > Shouldn't we be doing that flush on stream close instead?  If nothing
> > else the flush is going to discard a bit of data if the stream is just
> > paused.

> The FIFOs are only 8 frames in size, so I am not sure there is an
> issue with these frames being lost.

> I think it also makes sense to keep the blocks consistent with each
> other. The spdif (out and in), and parallel out, all flush automatically
> when stopped, and the fifo for the i2s out block is cleared when the
> reset is asserted.

This seems like an issue that got missed in the other drivers then.  I'd
expect the trigger operation to be a minimal operation which starts and
stops the data transfer, not doing anything else.

--E5HUUwS3R9LcK7+r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWMB8qAAoJECTWi3JdVIfQjyoH/AqvualpliASdv2dh3haXToA
dQ6tFIHMTCqNlWn0e4zljQmfOfhP8Ub8/NH/JOir2TQCgQD47TxUaqzoSr5V+JDc
uCFBj4PQsHzXEVypazrwQMEvCwcnTxAksZGDzjU34TtRHiDQaw/s7Lc6QqE7mba/
I3hc4a4LYJrUdjie+UM+j6SopxBQ4htpXDUpCUvBWLyq6wjuv8hBmXDlgV9uu2ex
oXtXNG2rKAGCYwgcsSlaw4yrza/78+noh+HkvEPna6gtkfTovd1oervQXss/XUtc
nEjI+k2syIEvNYK5vtICfmzYuAVuAfWOKKPq9gX0omQE/tiEb7/E4KZd9RBkeH0=
=kOxG
-----END PGP SIGNATURE-----

--E5HUUwS3R9LcK7+r--