From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755105AbbJ1CII (ORCPT ); Tue, 27 Oct 2015 22:08:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:51536 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754077AbbJ1CIF (ORCPT ); Tue, 27 Oct 2015 22:08:05 -0400 Date: Wed, 28 Oct 2015 11:07:50 +0900 From: Joerg Roedel To: Andy Lutomirski Cc: linux-kernel@vger.kernel.org, Christian Borntraeger , Cornelia Huck , Sebastian Ott , Paolo Bonzini , Christoph Hellwig , benh@kernel.crashing.org, KVM , dwmw2@infradead.org, Martin Schwidefsky , linux-s390 , Andy Lutomirski Subject: Re: [PATCH 1/3] virtio_net: Stop doing DMA from the stack Message-ID: <20151028020750.GB18467@suse.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2015 at 06:17:08PM -0700, Andy Lutomirski wrote: > From: Andy Lutomirski > > Once virtio starts using the DMA API, we won't be able to safely DMA > from the stack. virtio-net does a couple of config DMA requests > from small stack buffers -- switch to using dynamically-allocated > memory. > > This should have no effect on any performance-critical code paths. > > Signed-off-by: Andy Lutomirski > --- > drivers/net/virtio_net.c | 53 ++++++++++++++++++++++++++++++++---------------- > 1 file changed, 36 insertions(+), 17 deletions(-) Reviewed-by: Joerg Roedel