From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755538AbbJ1IAa (ORCPT ); Wed, 28 Oct 2015 04:00:30 -0400 Received: from mail.osadl.at ([92.243.35.153]:40896 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbbJ1IA3 (ORCPT ); Wed, 28 Oct 2015 04:00:29 -0400 Date: Wed, 28 Oct 2015 08:00:18 +0000 From: Nicholas Mc Guire To: Michal Marek Cc: Nicholas Mc Guire , "Yann E. MORIN" , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] Mark files generated by confdata.c Message-ID: <20151028080018.GB15362@osadl.at> References: <1445959842-1960-1-git-send-email-hofrat@osadl.org> <1445959842-1960-5-git-send-email-hofrat@osadl.org> <562FE99B.2020108@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <562FE99B.2020108@suse.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2015 at 10:16:11PM +0100, Michal Marek wrote: > Dne 27.10.2015 v 16:30 Nicholas Mc Guire napsal(a): > > scripts/kconfig/confdata.c generates a number of files - indicate the > > location of the generator in the file heading to ease reading the sources. > > > > Signed-off-by: Nicholas Mc Guire > > --- > > This is no actual code change - compile-testing should thus do > > checkpatch.pl will fuss about "WARNING: quoted string split across lines" > > but it seems this is fine in this case given the initial code. > > > > Compile tested with x86_64_defconfig > > > > Patch is against 4.3-rc6 (localversion-next is -next-20151022) > > > > scripts/kconfig/confdata.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > > index 0b7dc2f..6a2be59 100644 > > --- a/scripts/kconfig/confdata.c > > +++ b/scripts/kconfig/confdata.c > > @@ -651,7 +651,8 @@ conf_write_heading(FILE *fp, struct conf_printer *printer, void *printer_arg) > > > > snprintf(buf, sizeof(buf), > > "\n" > > - "Automatically generated file; DO NOT EDIT.\n" > > + "Automatically generated by scripts/kconfig/confdata.c:" > > + " DO NOT EDIT.\n" > > You cannot run the C source to regenerate the file, so how about > "generated by kconfig"? > Yup that makes more sense - and it would still point the reader into the right direction - will go check the other cases as well. thx! hofrat