From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753385AbbJ1RIl (ORCPT ); Wed, 28 Oct 2015 13:08:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47032 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbbJ1RIk (ORCPT ); Wed, 28 Oct 2015 13:08:40 -0400 Date: Wed, 28 Oct 2015 17:08:36 +0000 From: Aaron Tomlin To: akpm@linux-foundation.org Cc: riel@redhat.com, lwoodman@redhat.com, aarcange@redhat.com, kirill.shutemov@linux.intel.com, mgorman@suse.de, vbabka@suse.cz, willy@linux.intel.com, aneesh.kumar@linux.vnet.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thp: Remove unused vma parameter from khugepaged_alloc_page Message-ID: <20151028170836.GA18188@atomlin.usersys.redhat.com> References: <1446051905-21828-1-git-send-email-atomlin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1446051905-21828-1-git-send-email-atomlin@redhat.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2015-10-28 17:05 +0000, Aaron Tomlin wrote: > The "vma" parameter to khugepaged_alloc_page() is unused. > It has to remain unused or the drop read lock 'map_sem' optimisation > introduce by commit 8b1645685acf ("thp: introduce khugepaged_prealloc_page > and khugepaged_alloc_page") wouldn't be possible. So let's remove it. Self nack due to incorrect commit message. -- Aaron Tomlin