From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755639AbbJ1Uo4 (ORCPT ); Wed, 28 Oct 2015 16:44:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46599 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbbJ1Uoz (ORCPT ); Wed, 28 Oct 2015 16:44:55 -0400 Date: Wed, 28 Oct 2015 21:44:50 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Wang Nan , Linux Kernel Mailing List Subject: Re: tools/build: fixdep versus tools/lib/bpf Message-ID: <20151028204450.GA25553@krava.redhat.com> References: <20151028163040.GA19695@kernel.org> <20151028201352.GA14076@krava.brq.redhat.com> <20151028203752.GD19695@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151028203752.GD19695@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 05:37:52PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > Hi Jiri, Wang, > > > > > > I'm getting these while doing 'make -C tools/perf build-test': > > > > > > LD fixdep-in.o > > > LINK fixdep > > > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied > > > make[6]: *** [bpf.o] Error 1 > > > make[5]: *** [libbpf-in.o] Error 2 > > > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 > > > make[4]: *** Waiting for unfinished jobs.... > > > > > > > > > It happens at different tests, i.e. seems like a race somewhere in the > > > build system, can you take a look? It happens with my perf/ebpf branch. > > > > could not reproduce, but looks like attached patch should help > > I'll test this now, i.e. make it go thru a 'make -C tools/perf > build-test'. > > In the interest of speeding up things, please provide an explanation of > why this should be applied, so that I can add it to the changeset log. > > Thanks a bunch! > The fixdep tool needs to be built as the first binary. Libraries are built in paralel, so each of them needs to depend on fixdep target. jirka > > jirka > > > > > > --- > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > > index 1e2e2d1d26b7..0d19d5447d6c 100644 > > --- a/tools/perf/Makefile.perf > > +++ b/tools/perf/Makefile.perf > > @@ -430,7 +430,7 @@ $(LIBAPI)-clean: > > $(call QUIET_CLEAN, libapi) > > $(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null > > > > -$(LIBBPF): FORCE > > +$(LIBBPF): fixdep FORCE > > $(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a > > > > $(LIBBPF)-clean: