From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756494AbbJ1XoQ (ORCPT ); Wed, 28 Oct 2015 19:44:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39803 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754826AbbJ1XoO (ORCPT ); Wed, 28 Oct 2015 19:44:14 -0400 Date: Thu, 29 Oct 2015 08:43:34 +0900 From: Mark Brown To: Damien Horsley Cc: alsa-devel@alsa-project.org, James Hartley , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20151028234334.GF28319@sirena.org.uk> References: <1444653637-14711-1-git-send-email-Damien.Horsley@imgtec.com> <1444653637-14711-3-git-send-email-Damien.Horsley@imgtec.com> <20151019174732.GG32054@sirena.org.uk> <56293472.7000401@imgtec.com> <20151023225723.GO29919@sirena.org.uk> <562F824F.9070407@imgtec.com> <20151028010443.GX28319@sirena.org.uk> <56313B9C.8030502@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b/1LfoxmgmdMg2Yp" Content-Disposition: inline In-Reply-To: <56313B9C.8030502@imgtec.com> X-Cookie: "But I don't like Spam!!!!" User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 58.123.138.205 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --b/1LfoxmgmdMg2Yp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 28, 2015 at 09:18:20PM +0000, Damien Horsley wrote: > On 28/10/15 01:04, Mark Brown wrote: > >> I think it also makes sense to keep the blocks consistent with each > >> other. The spdif (out and in), and parallel out, all flush automatically > >> when stopped, and the fifo for the i2s out block is cleared when the > >> reset is asserted. > > This seems like an issue that got missed in the other drivers then. I'd > > expect the trigger operation to be a minimal operation which starts and > > stops the data transfer, not doing anything else. > The spdif out, spdif in, and parallel out blocks auto-flush whenever > they are stopped. It is not possible for software to prevent this behavior. Oh, so this isn't the drivers doing this? In that case it's fine for them to do that, if it's what the hardware does it's what the hardware does. It sounded like you were saying that there was similar code in the other drivers. --b/1LfoxmgmdMg2Yp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWMV2mAAoJECTWi3JdVIfQPaUH/jOiapc4JkMTkvvv9ZM+Tm/M lD+MciI97+XqrGEN52Tw+7PgxmFrNo4QKCph0q7P4mkdR+HoOi9vhaX6w5NikQUC YE1USNDZZyugIBvKmFHF3dUB7rTEFUd6VLF0KaiIN4cAbxXauJMWYo/9zt2UzeeS PdsrhYycJXSemHRvBItRXe3o5ID/Lar9gZJeFKUdOAHrBB4F0Xfsnj+JO8c1u3OV xlivtWavyqB3KhtRMIPey20bmgAUp7TKynmsi8XdvsD59dIAuhO9y9/F4S0t1uuI Ka92rmG2RxGfGjbW/p5xwUuPuxrON3adP9MhjKWbo2mYZ+0tuzMAolyMuKh1iiY= =g61v -----END PGP SIGNATURE----- --b/1LfoxmgmdMg2Yp--