From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild test robot <fengguang.wu@intel.com>
Subject: [for-next][PATCH 5/5] tracing: Fix sparse RCU warning
Date: Thu, 29 Oct 2015 03:07:59 -0400 [thread overview]
Message-ID: <20151029071032.496848028@goodmis.org> (raw)
In-Reply-To: <20151029070754.584668951@goodmis.org>
[-- Attachment #1: 0005-tracing-Fix-sparse-RCU-warning.patch --]
[-- Type: text/plain, Size: 1015 bytes --]
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
p_start() and p_stop() are seq_file functions that match. Teach sparse to
know that rcu_read_lock_sched() that is taken by p_start() is released by
p_stop.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_events.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 2b7fccd499c6..fb0261e90acc 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -938,6 +938,7 @@ static void t_stop(struct seq_file *m, void *p)
}
static void *p_start(struct seq_file *m, loff_t *pos)
+ __acquires(RCU)
{
struct trace_pid_list *pid_list;
struct trace_array *tr = m->private;
@@ -960,6 +961,7 @@ static void *p_start(struct seq_file *m, loff_t *pos)
}
static void p_stop(struct seq_file *m, void *p)
+ __releases(RCU)
{
rcu_read_unlock_sched();
mutex_unlock(&event_mutex);
--
2.6.1
prev parent reply other threads:[~2015-10-29 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 7:07 [for-next][PATCH 0/5] tracing: Addition of set_event_pid Steven Rostedt
2015-10-29 7:07 ` [for-next][PATCH 1/5] tracepoint: Give priority to probes of tracepoints Steven Rostedt
2015-10-29 17:52 ` Mathieu Desnoyers
2015-10-30 20:25 ` Steven Rostedt
2015-10-30 20:49 ` Mathieu Desnoyers
2015-10-29 7:07 ` [for-next][PATCH 2/5] tracing: Add set_event_pid directory for future use Steven Rostedt
2015-11-19 23:24 ` Paul E. McKenney
2015-11-20 4:17 ` Steven Rostedt
2015-12-01 18:12 ` Paul E. McKenney
2015-10-29 7:07 ` [for-next][PATCH 3/5] tracing: Implement event pid filtering Steven Rostedt
2015-10-29 7:07 ` [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids Steven Rostedt
2015-10-30 6:16 ` Jiaxing Wang
2015-10-30 20:28 ` Steven Rostedt
2015-10-29 7:07 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029071032.496848028@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome