From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030663AbbJ3LPn (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2015 07:15:43 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:33592 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758909AbbJ3LPk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2015 07:15:40 -0400
Date: Fri, 30 Oct 2015 20:15:36 +0900 (KST)
Message-Id: <20151030.201536.285461609251750460.davem@davemloft.net>
To: santosh.shilimkar@oracle.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ssantosh@kernel.org
Subject: Re: [net-next PATCH] RDS: convert bind hash table to re-sizable
 hashtable
From: David Miller <davem@davemloft.net>
In-Reply-To: <1446072672-4325-1-git-send-email-santosh.shilimkar@oracle.com>
References: <1446072672-4325-1-git-send-email-santosh.shilimkar@oracle.com>
X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 30 Oct 2015 04:15:39 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Date: Wed, 28 Oct 2015 15:51:12 -0700

> +					    &rs->rs_bound_node, ht_parms)) {
>  			*port = rs->rs_bound_port;
>  			ret = 0;
>  			rdsdebug("rs %p binding to %pI4:%d\n",
>  			  rs, &addr, (int)ntohs(*port));
>  			break;
>  		} else {
> -			rds_sock_put(rrs);
> +			rds_sock_put(rs);
> +			ret = -ENOMEM;
> +			break;
>  		}
> +
>  	} while (rover++ != last);
>  
>  	return ret;

This final insert of an empty line is both inappropriate and even
if it was it would not be related to this change.