From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757671AbbJ3BUn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Oct 2015 21:20:43 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40938 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757245AbbJ3BUl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Oct 2015 21:20:41 -0400
Date: Fri, 30 Oct 2015 10:20:20 +0900
From: Mark Brown <broonie@kernel.org>
To: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: alsa-devel@alsa-project.org, James Hartley <James.Hartley@imgtec.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <20151030012020.GO28319@sirena.org.uk>
References: <1444653637-14711-1-git-send-email-Damien.Horsley@imgtec.com>
 <1444653637-14711-3-git-send-email-Damien.Horsley@imgtec.com>
 <20151019174732.GG32054@sirena.org.uk>
 <56293472.7000401@imgtec.com>
 <20151023225723.GO29919@sirena.org.uk>
 <562F824F.9070407@imgtec.com>
 <20151028010443.GX28319@sirena.org.uk>
 <56313B9C.8030502@imgtec.com>
 <20151028234334.GF28319@sirena.org.uk>
 <56323E83.5010605@imgtec.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="4cokgWgqjr3t8EL1"
Content-Disposition: inline
In-Reply-To: <56323E83.5010605@imgtec.com>
X-Cookie: "But I don't like Spam!!!!"
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 222.106.49.2
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S
 input controller
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--4cokgWgqjr3t8EL1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 29, 2015 at 03:42:59PM +0000, Damien Horsley wrote:

> For the I2S In, there is another issue with flushing on stream close. If
> the stream is stopped, then reconfigured to use a larger number of
> channels (without the stream being closed), then the per-channel fifos
> will become inconsistent with each other. The new channels will have no
> samples in their FIFOs, while the others may contain samples from the
> previous stream.

> Would hw_params be the correct place to flush instead?

Yes, you could flush there (or in both places for that matter).

--4cokgWgqjr3t8EL1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWMsXTAAoJECTWi3JdVIfQScQIAIUUol1l/hftAmRCj1o4rstl
VfdYytoikfmuGsLzQ1NtQ+KohYWRM20kRErAqwtt3DWSxyLmLUCbXuRyapy3v+f6
YpWhUlsXD7NSRSW5d5vomPWm0uSQn3CwbgiVcWncf0WOdox31LjHjg+uB5GJGCFL
8+gdsSRrKrYj3uZ4C7SoVFrLX5NFP/mEmiLeVm+TJFus9PI8JBMPVc84x1EJVtQL
0Sp1/8E5CZddDmsSqJYFySTNDNCX2BC57yuxeG1dVKkiVls3/oSEA6YGJj8Ciw4V
0PtBLDVcQgobnN6CVQER1Fv1K6Sc/rvw/Y5tyM0wxy9IkFYRdodWhxsRZF6nx/c=
=db4Y
-----END PGP SIGNATURE-----

--4cokgWgqjr3t8EL1--