From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757803AbbJ3FIk (ORCPT ); Fri, 30 Oct 2015 01:08:40 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:60731 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbbJ3FIi (ORCPT ); Fri, 30 Oct 2015 01:08:38 -0400 X-Helo: d28dlp03.in.ibm.com X-MailFrom: weiyang@linux.vnet.ibm.com X-RcptTo: linux-pci@vger.kernel.org Date: Fri, 30 Oct 2015 13:08:25 +0800 From: Wei Yang To: Bjorn Helgaas Cc: Alexander Duyck , linux-pci@vger.kernel.org, Ethan Zhao , Wei Yang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] PCI: Remove redundant validation of SR-IOV offset/stride registers Message-ID: <20151030050825.GA5119@richards-mbp.cn.ibm.com> Reply-To: Wei Yang References: <20151029221701.11908.82718.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20151029222301.11908.97709.stgit@bhelgaas-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151029222301.11908.97709.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15103005-0025-0000-0000-000007CC9C90 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2015 at 05:23:01PM -0500, Bjorn Helgaas wrote: >From: Alexander Duyck > >Previously, we read, validated, and cached PCI_SRIOV_VF_OFFSET and >PCI_SRIOV_VF_STRIDE in sriov_enable(). But sriov_init() now does >that via compute_max_vf_buses(), so we don't need to do it again. > >Remove the PCI_SRIOV_VF_OFFSET and PCI_SRIOV_VF_STRIDE config reads from >sriov_enable(). The pci_sriov structure already contains the offset and >stride corresponding to the current NumVFs. > >[bhelgaas: split to separate patch for reviewability] >Signed-off-by: Alexander Duyck >Signed-off-by: Bjorn Helgaas Reviewed-by: Wei Yang >--- > drivers/pci/iov.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > >diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c >index 1b1acc2..ca400a9 100644 >--- a/drivers/pci/iov.c >+++ b/drivers/pci/iov.c >@@ -235,7 +235,7 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) > int rc; > int i, j; > int nres; >- u16 offset, stride, initial; >+ u16 initial; > struct resource *res; > struct pci_dev *pdev; > struct pci_sriov *iov = dev->sriov; >@@ -258,11 +258,6 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) > (!(iov->cap & PCI_SRIOV_CAP_VFM) && (nr_virtfn > initial))) > return -EINVAL; > >- pci_read_config_word(dev, iov->pos + PCI_SRIOV_VF_OFFSET, &offset); >- pci_read_config_word(dev, iov->pos + PCI_SRIOV_VF_STRIDE, &stride); >- if (!offset || (nr_virtfn > 1 && !stride)) >- return -EIO; >- > nres = 0; > for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) { > bars |= (1 << (i + PCI_IOV_RESOURCES)); >@@ -275,9 +270,6 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) > return -ENOMEM; > } > >- iov->offset = offset; >- iov->stride = stride; >- > bus = pci_iov_virtfn_bus(dev, nr_virtfn - 1); > if (bus > dev->bus->busn_res.end) { > dev_err(&dev->dev, "can't enable %d VFs (bus %02x out of range of %pR)\n", -- Richard Yang Help you, Help me