From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932844AbbJ3UZl (ORCPT ); Fri, 30 Oct 2015 16:25:41 -0400 Received: from smtprelay0205.hostedemail.com ([216.40.44.205]:40354 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932807AbbJ3UZk (ORCPT ); Fri, 30 Oct 2015 16:25:40 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:2731:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4362:5007:6119:6261:7576:7875:7903:10004:10394:10400:10848:10967:11232:11658:11914:12043:12050:12296:12517:12519:12663:12740:13069:13138:13149:13230:13231:13311:13357:14096:14097:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: juice06_6b88116e75100 X-Filterd-Recvd-Size: 2666 Date: Fri, 30 Oct 2015 16:25:37 -0400 From: Steven Rostedt To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of tracepoints Message-ID: <20151030162537.6409d174@gandalf.local.home> In-Reply-To: <385418149.12792.1446141136941.JavaMail.zimbra@efficios.com> References: <20151029070754.584668951@goodmis.org> <20151029071031.832974028@goodmis.org> <385418149.12792.1446141136941.JavaMail.zimbra@efficios.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Oct 2015 17:52:16 +0000 (UTC) Mathieu Desnoyers wrote: > ----- On Oct 29, 2015, at 3:07 AM, rostedt rostedt@goodmis.org wrote: > > > From: "Steven Rostedt (Red Hat)" > > > > In order to guarantee that a probe will be called before other probes that > > are attached to a tracepoint, there needs to be a mechanism to provide > > priority of one probe over the others. > > > > Adding a prio field to the struct tracepoint_func, which lets the probes be > > sorted by the priority set in the structure. If no priority is specified, > > then a priority of 10 is given (this is a macro, and perhaps may be changed > > in the future). > > > > Now probes may be added to affect other probes that are attached to a > > tracepoint with a guaranteed order. > > > > One use case would be to allow tracing of tracepoints be able to filter by > > pid. A special (higher priority probe) may be added to the sched_switch > > tracepoint and set the necessary flags of the other tracepoints to notify > > them if they should be traced or not. In case a tracepoint is enabled at the > > sched_switch tracepoint too, the order of the two are not random. > > > > Cc: Mathieu Desnoyers > > Signed-off-by: Steven Rostedt > > Sounds good to me, > > Acked-by: Mathieu Desnoyers > Thanks. Unfortunately I already pushed it out to linux-next (had a deadline), otherwise I could have added your ack. I'm guessing you missed the RFC version I posted a week ago. -- Steve