From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932775AbbJ3U2t (ORCPT ); Fri, 30 Oct 2015 16:28:49 -0400 Received: from smtprelay0194.hostedemail.com ([216.40.44.194]:34035 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752504AbbJ3U2s (ORCPT ); Fri, 30 Oct 2015 16:28:48 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2895:3138:3139:3140:3141:3142:3308:3352:3622:3865:3866:3867:3870:3871:3874:4605:5007:6119:6261:7514:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12740:13069:13255:13311:13357:13972:14096:14097:21080:30051:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: suit59_86e91ef69100d X-Filterd-Recvd-Size: 1949 Date: Fri, 30 Oct 2015 16:28:45 -0400 From: Steven Rostedt To: Jiaxing Wang Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids Message-ID: <20151030162845.41dc028e@gandalf.local.home> In-Reply-To: <20151030061643.GA19480@cac> References: <20151029070754.584668951@goodmis.org> <20151029071032.334291716@goodmis.org> <20151030061643.GA19480@cac> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2015 14:16:43 +0800 Jiaxing Wang wrote: > On Thu, Oct 29, 2015 at 03:07:58AM -0400, Steven Rostedt wrote: > > static ssize_t > > ftrace_event_pid_write(struct file *filp, const char __user *ubuf, > > size_t cnt, loff_t *ppos) > > @@ -1711,6 +1727,12 @@ ftrace_event_pid_write(struct file *filp, const char __user *ubuf, > > tr, INT_MAX); > > register_trace_prio_sched_wakeup(event_filter_pid_sched_wakeup_probe_post, > > tr, 0); > > + > > + /* > > + * Ignoring of pids is done at task switch. But we have to > > + * check for those tasks that are currently running. > > + */ > > + on_each_cpu(ignore_task_cpu, tr, 1); > > } > on_each_cpu(ignore_task_cpu, tr, 1); can be put outside of the else > block, then ignore_pid can be updated when appending pid, > eg. echo 'xxx' >> set_event_pid, in case xxx is running on some cpu. Hmm, I guess I could. -- Steve > > > > mutex_unlock(&event_mutex);