From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbbJaA13 (ORCPT ); Fri, 30 Oct 2015 20:27:29 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34209 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbbJaA10 (ORCPT ); Fri, 30 Oct 2015 20:27:26 -0400 Date: Fri, 30 Oct 2015 17:27:23 -0700 From: Brian Norris To: linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Felipe Balbi , tony@atomide.com, stable@vger.kernel.org Subject: Re: [PATCH] mtd: blkdevs: fix potential deadlock + lockdep warnings Message-ID: <20151031002723.GN13239@google.com> References: <1445913529-19887-1-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445913529-19887-1-git-send-email-computersforpeace@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2015 at 07:38:49PM -0700, Brian Norris wrote: > Commit 073db4a51ee4 ("mtd: fix: avoid race condition when accessing > mtd->usecount") fixed a race condition but due to poor ordering of the > mutex acquisition, introduced a potential deadlock. [...] > > Fixes: 073db4a51ee4 ("mtd: fix: avoid race condition when accessing mtd->usecount") > Reported-by: Felipe Balbi > Tested-by: Felipe Balbi > Signed-off-by: Brian Norris > Cc: Pushed to l2-mtd.git. > --- > Resending as a proper patch > > Note: I tried to reproduce this lockdep warning myself but couldn't. But I saw > no problem under the new patch either.