From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbbKARPI (ORCPT ); Sun, 1 Nov 2015 12:15:08 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:53939 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752567AbbKARPE (ORCPT ); Sun, 1 Nov 2015 12:15:04 -0500 Date: Sun, 01 Nov 2015 12:15:02 -0500 (EST) Message-Id: <20151101.121502.1753196778636094034.davem@davemloft.net> To: stefanha@redhat.com Cc: netdev@vger.kernel.org, pv-drivers@vmware.com, linux-kernel@vger.kernel.org, jhansen@vmware.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] VSOCK: define VSOCK_SS_LISTEN once only From: David Miller In-Reply-To: <1446119862-24369-1-git-send-email-stefanha@redhat.com> References: <1446119862-24369-1-git-send-email-stefanha@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 01 Nov 2015 09:15:04 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Hajnoczi Date: Thu, 29 Oct 2015 11:57:42 +0000 > The SS_LISTEN socket state is defined by both af_vsock.c and > vmci_transport.c. This is risky since the value could be changed in one > file and the other would be out of sync. > > Rename from SS_LISTEN to VSOCK_SS_LISTEN since the constant is not part > of enum socket_state (SS_CONNECTED, ...). This way it is clear that the > constant is vsock-specific. > > The big text reflow in af_vsock.c was necessary to keep to the maximum > line length. Text is unchanged except for s/SS_LISTEN/VSOCK_SS_LISTEN/. > > Signed-off-by: Stefan Hajnoczi Applied to net-next, thanks.