From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbbKABxL (ORCPT ); Sat, 31 Oct 2015 21:53:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59373 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbbKABxF (ORCPT ); Sat, 31 Oct 2015 21:53:05 -0400 Date: Sat, 31 Oct 2015 21:53:01 -0400 From: Jessica Yu To: Chris J Arges Cc: live-patching@vger.kernel.org, Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory Message-ID: <20151101015258.GA8199@packer-debian-8-amd64.digitalocean.com> References: <1446263060-22175-1-git-send-email-chris.j.arges@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1446263060-22175-1-git-send-email-chris.j.arges@canonical.com> X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Chris J Arges [30/10/15 22:44 -0500]: >The following directory structure will allow for cases when the same >function name exists in a single object. > /sys/kernel/livepatch/// Hi Chris, thanks for the patch. I think the last time this issue was discussed, the conclusion was that concatenating the address to the function name constitutes as an information leak (as the sysfs entry is visible to non-root users). One option suggested by Josh in that thread would be to do something like "func.n", where n is just the nth occurrence of the symbol name. Another option might be to keep the func@addr format but not make these entries visible to non-root users. Jessica