From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753912AbbKBUy5 (ORCPT ); Mon, 2 Nov 2015 15:54:57 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:35478 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753737AbbKBUyz (ORCPT ); Mon, 2 Nov 2015 15:54:55 -0500 Date: Mon, 02 Nov 2015 15:54:52 -0500 (EST) Message-Id: <20151102.155452.2035474549929551377.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch, linux@roeck-us.net, narmstrong@baylibre.com Subject: Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: lookup switch name From: David Miller In-Reply-To: <1446248388-21060-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1446248388-21060-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Nov 2015 12:54:54 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Fri, 30 Oct 2015 19:39:48 -0400 > All the mv88e6xxx drivers use the exact same code in their probe > function to lookup the switch name given its ID. Thus introduce a > mv88e6xxx_switch_id structure and a mv88e6xxx_lookup_name function in > the common mv88e6xxx code. > > In the meantime make __mv88e6xxx_reg_{read,write} static since we do not > need to expose these low-level r/w routines anymore. > > Signed-off-by: Vivien Didelot Applied.