From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbbKBEqj (ORCPT ); Sun, 1 Nov 2015 23:46:39 -0500 Received: from mail-bn1bon0088.outbound.protection.outlook.com ([157.56.111.88]:31330 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751576AbbKBEqg (ORCPT ); Sun, 1 Nov 2015 23:46:36 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; 01.org; dkim=none (message not signed) header.d=none;01.org; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NX67XJ-07-E0N-02 X-M-MSG: Date: Mon, 2 Nov 2015 12:45:35 +0800 From: Huang Rui To: kbuild test robot CC: , Borislav Petkov , Guenter Roeck , Peter Zijlstra , Jean Delvare , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , "Ingo Molnar" , "Rafael J. Wysocki" , "Len Brown" , John Stultz , =?utf-8?B?RnLvv71k77+9cmlj?= Weisbecker , , , , Andreas Herrmann , Aravind Gopalakrishnan , Borislav Petkov , Fengguang Wu , Aaron Lu , SPG_Linux_Kernel Subject: Re: [PATCH v3 06/10] hwmon: (fam15h_power) Add compute unit accumulated power Message-ID: <20151102044534.GA24402@hr-amur2> References: <1446199024-1896-7-git-send-email-ray.huang@amd.com> <201510301835.gZzXFZav%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <201510301835.gZzXFZav%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(24454002)(199003)(189002)(164054003)(2950100001)(50466002)(5890100001)(5007970100001)(92566002)(87936001)(1720100001)(77096005)(105586002)(19625735002)(4001350100001)(11100500001)(15975445007)(101416001)(46406003)(97736004)(33656002)(5008740100001)(50986999)(47776003)(76176999)(97756001)(5001920100001)(23726002)(86362001)(106466001)(83506001)(54356999)(110136002)(33716001)(19580395003)(189998001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0716;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;2:9MSJvoA0edaGh76/SMuwrforaqy72N+iwTj+Lzd0z/L5NosQzrmvCNZ9C5MbhmYFLKIDdIhPd4DAqXAA4SVkjg95UL6XDytJvjz/eQr4YbuZoOpOi6fuiG20XDwQ81gI/3NpaAK5Nmta80zvdF/1DYFkdCKXpOQfinRdW/f2nRM=;3:JJXmdzVr7uqVK7MTL/6rXgqOF+3cRGPoba+cSkFZIJbyiWLIS25X84BjZzXXzYUodEOHPu+xzfBeS2X0MLQMwUW2pG+H6Y1otq6hkwEjAqEY8N1pDiy+CcUwCPvahrkB01DqxvLYOwNDPxun/GLTjfssuoMgW0k/R+B7A8yhj44EoaHYK7POpQs7QKw7LaM3heR0b4Z3u58KPp6VIkMfwo8cysekWX0Y98D5s49s8y3343N+bwpswggIL7VoJnhJ;25:8iQZoEDfZYZOK1rsKnGjSj54UgZqtuSu27jF3gLJ96EHaMft1VHfwkSremsWAf5y4xCNXK/2B4u4NkZYueVrqy4jHYeH0iH1a/jKLdH2KVqxhj0yRp1P1XXoMmPKtH+Nz+i6IJQ7ydcWbIEYNLlsXkIE7+ImU43q7mOs3Nj4Xhz7umAwVXoL29u4skkAxzEJPMtftgqZ/og8X45HlCwIvayURqjnlk7gnoru2O1L8+j8ZF2G1j3yHt90+LcnZe54pgxU/DNJmVODrph3wFi7pA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0716; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;20:JAKa7j3p6VhzO8nzP1BYVI7kXfhWDDVUDxDaSHMJRI1V4B2kaZ+vWC75H1Y9e6zc5zjhssdBDqXLIV86BKYg9IX929j9TvWH34MMcjKjNz070gg6x7M4QnBh+l/BVURyyXHdvxO8q5Z5nnNx1SEXN+8W6nMoOWp97YnQoQz4CxecBsHWh/GKvF5jzoB6VpCajXclmL7NqSfj15D30desxY+QB0IG6puVBJOvtfyUW2wyr0US8WKkUf8nOkZ3C5ZlRPQqDV3SoPUUF2tVqVVEMPiijAXydjFNMB3sE2rmxzef4XeuU1JLVjuvqA/GTj0SDiVDuX+AwC4NXMyBrRZJHDYO4nYaa8Fs3cuaYQWGx/pAOHHDBk61ThGNMrTfto9ZMpbDd8Kq5ybezR0dZMLY9KsA2WJKWrmucNa1P/vWgz/FYrV5YXxZcC0TwlPGkpoEPPV+SFc0hPNpffjaG7/vZDtgdKRfJ46khSNSJvsZa3/6aRvdjSylpbNinzASogNX;4:naI914SaYTbm1Be6pO4I2vxJSHlYVe1jGqRD43kIo5lnz6c4saa2L4oA/xD5yt+wKEO7y3iFzrse8g6hMKF4Uy+C6kGGWxupoM04ZsFEHBDLdntHlicAWo+qeMLuY0+EGoVdv62lonGA9BQolcjKcTpkUvbPhtdvh4zD8KSbh86DDALOH4GAFxjFI9vmZE1VfO0JMEq6oF3l5EQ+Oq6hPm65Iq4X1N9x0U7APb+exWz0PYVsa50rT45Esf1hKPkdo4GXe9F1+ur5+E3PvQElAtOS773ee5NeSbqwRWAO2I9TEufnZHBeWAA+fJV/S49ggz/UHgyUMVBPp2553y/pvYweFRF9Iby4Po7Pl9LmEDDdaajBhYvAV4RLpGjQDLUa X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:CY1PR12MB0716;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0716; X-Forefront-PRVS: 0748FF9A04 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR12MB0716;23:2iXazL/TxTHkVqsQlZBI2qEpMP3q1JCuk87kAXXG8?= =?us-ascii?Q?BPweXMS+vtypr1y3VjDCk0RUDlKET4pTYoyu821lMmVM3l6H4n+MPSZXS/Th?= =?us-ascii?Q?jEgG4AiiM/NYMUc2zYxyEQW7ZPKUxuEw49gFUOastHPchrFilKrGY4rMLhck?= =?us-ascii?Q?ykjcZSsQaQjy/a/Hk+L76u6LuvQGxPa75iBM28kOo62mpsqjkcQSHKPzjoaJ?= =?us-ascii?Q?lawV1DJrvCrENCpjGLCMdTu8U8YWltxrv+XTf6PEtpon5X1i4+mYZj/eBtQf?= =?us-ascii?Q?G5QCcLFDSquJ96JlCNX4wmLViDZAH2p2u4m+qcgaWVFgsQvZZsz14RwdvtQp?= =?us-ascii?Q?iJq4QKOeOSgp2zh9hJ+9SKKwgJbew6cw2kjbfM+Ec4hFUSL8kfDwR+Tawbsn?= =?us-ascii?Q?RPRwZ/jYWWGA37lW0FVFeOkuTqKCjaT9byygD5jxLg1ToPiqWdtr7NfXFSAk?= =?us-ascii?Q?pD+C+BBNEjJor4BrqSeHw2izru3h4oy5IqYidXxpYL7MPSrAV+cpseiUHXjq?= =?us-ascii?Q?MbFasygR1ncjIZ43zHfpBsX3tp42sTy5EEbwGdD/jtE0im0aAnsAym1qEXIZ?= =?us-ascii?Q?Eayk2vPf+MF5sDBKS4YYSyeXU49//Eg4mIpjwTyBcoms6jgdlUVx7vGTNSBG?= =?us-ascii?Q?pUDNcIcB6/5XLk4mZ6niOeTYaKQnCXDqwU/H+a0I6ckjzMzkMwGJ0URUwylL?= =?us-ascii?Q?YV4qhQKK7twI9xuWZ6dlF+OgbLTuAUo73fc8MWUKejFJmYyWmGC3XZge0d2i?= =?us-ascii?Q?A+PMvQURz4iH403JcRM9uWe3trUqFkH7S2F65AMizsnsC+O1nlF8lvlgM1UU?= =?us-ascii?Q?HkvKNhPrzmtXOQCLdfVX0taOQTqovGppC0uny4tOUGAgyeQUzrqHMSE9foAf?= =?us-ascii?Q?7NTc+yhF3khyBnF6XXjbTkmOTttdh8DQwhIBv9O0dpNC4WvT9juE4eUFJMZt?= =?us-ascii?Q?5Gx1Mq2COTL8YQ4z644fwRMTU9TgTZcnQDjxiU5aFrRckosHS+GDYf62J7en?= =?us-ascii?Q?wjhi2zHPfsiYZ9nju/HxL5l41tx84P9969HLe+I2FgQTqqQ1NtEbCykm35BP?= =?us-ascii?Q?8+w3QftKfHMStGpq5o0rJrgkQgl73MA647i5x9FWqbRg/AAhA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;5:Cd+9KJvovZ4nJ1isEF3rU+qFwjEyInT2zazGTNm3CBkZdepV6RlgV3kLEuhyfpDgEPMKCDJm2YzRpKAw7udi5PYAPrfWHSPXStq+nKEuNWhQmLf7Qos4hkD5TwDpjadP91zjdyU81AA6RdecK0IiNw==;24:4D6RTQkold+5Qi9E/H/cBLkTsz0SYEUhZsBDppO9XP6RNs9EDuqR5BXiRr43tMfdtdxVg+pAAYXL4NvDmJ2tyRXQgqmrxeDKzO86DMGA38I=;20:QeefKIk3WyZnG2/zt6kmZIHyEjl2gtI0iDbv6ydlg/bu/1eHXVD3hfW6MkhyedoS9qzpXkBScqq/cwyctbdLXRjvM2+x3asX6WLvRoDvlVXINiH99H70dYXgHS2I/vrdHZP0VmbujgbGIyUD716hZpkgHkxkDh1qU2GC9Z3PYLfs8uw6pAp8reBSLoTlfun3AJsGgQ62oYWuktc/LGYCHjbHRuGIAe25Llt7l1e3axs+91UvC/p1U7nzaJmxMn8o SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2015 04:46:31.8421 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0716 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2015 at 06:33:42PM +0800, kbuild test robot wrote: > Hi Huang, > > [auto build test WARNING on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] > > url: https://github.com/0day-ci/linux/commits/Huang-Rui/hwmon-fam15h_power-Introduce-an-accumulated-power-reporting-algorithm/20151030-181426 > config: x86_64-randconfig-x012-10300134 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > Note: it may well be a FALSE warning. FWIW you are at least aware of it now. > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings > > All warnings (new ones prefixed by >>): > > In file included from arch/x86/include/asm/cpumask.h:4:0, > from arch/x86/include/asm/msr.h:10, > from arch/x86/include/asm/processor.h:20, > from arch/x86/include/asm/atomic.h:6, > from include/linux/atomic.h:4, > from include/linux/debug_locks.h:5, > from include/linux/lockdep.h:23, > from include/linux/spinlock_types.h:18, > from include/linux/mutex.h:15, > from include/linux/kernfs.h:13, > from include/linux/sysfs.h:15, > from include/linux/kobject.h:21, > from include/linux/device.h:17, > from include/linux/hwmon-sysfs.h:23, > from drivers/hwmon/fam15h_power.c:23: > drivers/hwmon/fam15h_power.c: In function 'fam15h_power_probe': > >> include/linux/cpumask.h:24:29: warning: 'res_mask' may be used uninitialized in this function [-Wmaybe-uninitialized] > #define cpumask_bits(maskp) ((maskp)->bits) > ^ > drivers/hwmon/fam15h_power.c:145:32: note: 'res_mask' was declared here > cpumask_var_t mask, tmp_mask, res_mask; > ^ Thank you to capture it! That's because my machine doesn't enable CONFIG_CPUMASK_OFFSTACK. So I didn't find this issue before. :) It needs to allocate res_mask like below: --- diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c index 71c9e6c..499776b 100644 --- a/drivers/hwmon/fam15h_power.c +++ b/drivers/hwmon/fam15h_power.c @@ -172,6 +172,10 @@ static int read_registers(struct fam15h_power_data *data) if (!ret) return -ENOMEM; + ret = zalloc_cpumask_var(&res_mask, GFP_KERNEL); + if (!ret) + return -ENOMEM; + get_online_cpus(); this_cpu = get_cpu(); @@ -199,6 +203,7 @@ static int read_registers(struct fam15h_power_data *data) put_cpu(); put_online_cpus(); + free_cpumask_var(res_mask); free_cpumask_var(tmp_mask); free_cpumask_var(mask); --- Thanks, Rui