From: Michal Hocko <mhocko@kernel.org>
To: "Huang, Ying" <ying.huang@linux.intel.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Vitaly Wool <vitalywool@gmail.com>,
David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [lkp] [mm, page_alloc] 43993977ba: +88% OOM possibility
Date: Mon, 2 Nov 2015 10:53:35 +0100 [thread overview]
Message-ID: <20151102095334.GE630@dhcp22.suse.cz> (raw)
In-Reply-To: <87twp4232k.fsf@yhuang-dev.intel.com>
On Mon 02-11-15 16:55:15, Huang, Ying wrote:
> Michal Hocko <mhocko@kernel.org> writes:
[...]
> > It would be interesting to see all the page allocation failure warnings
> > (if they are different). Maybe other callers have relied on GFP_ATOMIC
> > and access to memory reserves. The above path is not this case though.
>
> I take a look at all dmesgs, and found the backtrace for page allocation
> failure is same for all. Is it possible that this commit cause more
> memory were allocated or kept in memory so that more OOM were triggered?
I can imagine that some of the callers were not converted properly or
missed and a lack of __GFP_KSWAPD_RECLAIM could indeed cause a later
kswapd kick off. I am staring into the commit but nothing has jumped at
me yet. Could you collect /proc/vmstat (snapshot every 1s) on both good
and bad kernels. I expect the later would see a less scanning by kswapd.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2015-11-02 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 5:36 kernel test robot
2015-10-29 14:24 ` Michal Hocko
2015-10-30 8:21 ` Huang, Ying
2015-10-30 10:38 ` Michal Hocko
2015-11-01 23:20 ` Huang, Ying
2015-11-02 7:45 ` Michal Hocko
2015-11-02 8:55 ` Huang, Ying
2015-11-02 9:53 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102095334.GE630@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mgorman@techsingularity.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=vitalywool@gmail.com \
--cc=ying.huang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®