mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: conchur@web.de
Cc: linux-kernel@vger.kernel.org,
	"Ben Hutchings" <ben@decadent.org.uk>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Danilo Cesar Lemes de Paula" <danilo.cesar@collabora.co.uk>,
	"Jérémy Bobbio" <lunar@debian.org>,
	"Johannes Berg" <johannes.berg@intel.com>,
	"Bart Van Assche" <bart.vanassche@sandisk.com>
Subject: Re: kernel-doc: Not stripped #define/#ifdef/#endif in enums
Date: Mon, 2 Nov 2015 10:16:28 -0700	[thread overview]
Message-ID: <20151102101628.68f7324a@lwn.net> (raw)
In-Reply-To: <trinity-17181830-7fff-46ae-9d8d-939646858f15-1446394811425@3capp-webde-bap36>

On Sun, 1 Nov 2015 17:20:11 +0100
conchur@web.de wrote:

> just noticed that #define in kernel-doc are not correctly stripped
> anymore from enums. Here is my patch

Thanks for your patches, but I can't apply them in their current form.
Could you please do me a favor and:

 - Include changelogs that say why the changes are being made - what is
   the problem with how things are now?

 - Include a proper signoff.  See Documentation/SubmittingPatches for
   details.

You can probably trim the CC list somewhat the next time around as well.

Thanks,

jon

  reply	other threads:[~2015-11-02 17:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-01 16:20 conchur
2015-11-02 17:16 ` Jonathan Corbet [this message]
2015-11-20 11:27   ` Aw: " conchur
2015-11-20 14:37     ` Jonathan Corbet
2015-11-20 19:49       ` Aw: " conchur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151102101628.68f7324a@lwn.net \
    --to=corbet@lwn.net \
    --cc=akpm@linux-foundation.org \
    --cc=bart.vanassche@sandisk.com \
    --cc=ben@decadent.org.uk \
    --cc=conchur@web.de \
    --cc=danilo.cesar@collabora.co.uk \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lunar@debian.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®