From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754307AbbKBSWy (ORCPT ); Mon, 2 Nov 2015 13:22:54 -0500 Received: from smtprelay0024.hostedemail.com ([216.40.44.24]:43912 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753075AbbKBSWv (ORCPT ); Mon, 2 Nov 2015 13:22:51 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3151:3353:3622:3865:3866:3867:3870:3871:3874:5007:6261:7875:10004:10400:10450:10455:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:13972:14096:14097:19904:19999:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: use68_527acc9f3923a X-Filterd-Recvd-Size: 2754 Date: Mon, 2 Nov 2015 13:22:45 -0500 From: Steven Rostedt To: Geliang Tang Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: fix compiler warnings in trace_events.c Message-ID: <20151102132245.430223ef@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Nov 2015 00:00:43 -0800 Geliang Tang wrote: > Fix the following warnings: > kernel/trace/trace_events.c: In function '__ftrace_clear_event_pids': > kernel/trace/trace_events.c:579: warning: passing argument 1 of 'unregister_trace_sched_switch' from incompatible pointer type > include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool, struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)' > kernel/trace/trace_events.c:580: warning: passing argument 1 of 'unregister_trace_sched_switch' from incompatible pointer type > include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool, struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)' > kernel/trace/trace_events.c: In function 'ftrace_event_pid_write': > kernel/trace/trace_events.c:1724: warning: passing argument 1 of 'register_trace_prio_sched_switch' from incompatible pointer type > include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool, struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)' > kernel/trace/trace_events.c:1726: warning: passing argument 1 of 'register_trace_prio_sched_switch' from incompatible pointer type > include/trace/events/sched.h:162: note: expected 'void (*)(void *, bool, struct task_struct *, struct task_struct *)' but argument is of type 'void (*)(void *, struct task_struct *, struct task_struct *)' > > Signed-off-by: Geliang Tang This is something that Linus is going to have to fix when he merges both trees. This patch wont work with either of them without the other already merged. -- Steve