From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754465AbbKBS0Q (ORCPT ); Mon, 2 Nov 2015 13:26:16 -0500 Received: from smtprelay0143.hostedemail.com ([216.40.44.143]:55984 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752669AbbKBS0L (ORCPT ); Mon, 2 Nov 2015 13:26:11 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3622:3868:3870:3871:3872:4605:5007:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12517:12519:12740:13069:13311:13357:21080:21212:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: fowl38_6fee146247216 X-Filterd-Recvd-Size: 1719 Date: Mon, 2 Nov 2015 13:26:08 -0500 From: Steven Rostedt To: libin Cc: Will Deacon , kbuild test robot , , , , , , , , Subject: Re: [PATCH] recordmcount: arm64: replace the ignored mcount call into nop Message-ID: <20151102132608.59e16994@gandalf.local.home> In-Reply-To: <5633077C.3050000@huawei.com> References: <1446019445-14421-1-git-send-email-huawei.libin@huawei.com> <201510292118.ZYBYzBGa%fengguang.wu@intel.com> <20151029150922.GE3440@arm.com> <5633077C.3050000@huawei.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2015 14:00:28 +0800 libin wrote: > It is a bug in nop_mcount: > ... > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) { > if (make_nop) { > ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset); > } > ... > > shdr->sh_offset and welp->r_offset should handle endianness properly as _w(shdr->sh_offset)/ > _w(relp->r_offset). I will post a patchset including this patch soon. > Has this been fixed yet? -- Steve