From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932145AbbKBP3M (ORCPT ); Mon, 2 Nov 2015 10:29:12 -0500 Received: from down.free-electrons.com ([37.187.137.238]:47300 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752246AbbKBP3K (ORCPT ); Mon, 2 Nov 2015 10:29:10 -0500 Date: Mon, 2 Nov 2015 16:29:06 +0100 From: Thomas Petazzoni To: Vinod Koul Cc: Han Xu , fabio.estevam@freescale.com, boris.brezillon@free-electrons.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, hofrat@osadl.org, shijie.huang@arm.com, dan.j.williams@intel.com, computersforpeace@gmail.com, dwmw2@infradead.org Subject: Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Message-ID: <20151102162906.1e3c29da@free-electrons.com> In-Reply-To: <20151031014244.GF21326@localhost> References: <1445983540-27155-1-git-send-email-b45815@freescale.com> <1445983540-27155-3-git-send-email-b45815@freescale.com> <20151031014244.GF21326@localhost> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vinod, On Sat, 31 Oct 2015 07:12:44 +0530, Vinod Koul wrote: > On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote: > > > > -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma) > > +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma) > > This change seems unrelated to patch description, can you explain why? It seems related: mxs_dma_init() is now no longer called at initialization time, but also when resuming, as visible... > > > +#ifdef CONFIG_PM_SLEEP > > +static int mxs_dma_pm_resume(struct device *dev) > > +{ > > + struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev); > > + int ret; > > + > > + ret = mxs_dma_init(mxs_dma); ... here. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com