From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753657AbbKBWvr (ORCPT ); Mon, 2 Nov 2015 17:51:47 -0500 Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:45678 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751249AbbKBWvp (ORCPT ); Mon, 2 Nov 2015 17:51:45 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2895:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3871:4250:4321:4362:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12043:12517:12519:12555:12740:13069:13311:13357:14093:14097:21080:30012:30029:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cork54_667396fb3d527 X-Filterd-Recvd-Size: 2719 Date: Mon, 2 Nov 2015 17:51:42 -0500 From: Steven Rostedt To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Dave Hansen Subject: Re: [PATCH 1/3] Tracepoint: fix documentation of RCU lockdep checks Message-ID: <20151102175142.260e4246@gandalf.local.home> In-Reply-To: <1446504164-21563-1-git-send-email-mathieu.desnoyers@efficios.com> References: <1446504164-21563-1-git-send-email-mathieu.desnoyers@efficios.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Nov 2015 17:42:42 -0500 Mathieu Desnoyers wrote: > The documentation on top of __DECLARE_TRACE() does not match its > implementation since the condition check has been added to the > RCU lockdep checks. Update the documentation to match its > implementation. > Thanks, I can pull this now for 4.4. -- Steve > Fixes: a05d59a56733 "tracing: Add condition check to RCU lockdep checks" > Signed-off-by: Mathieu Desnoyers > CC: Dave Hansen > CC: Steven Rostedt > --- > include/linux/tracepoint.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h > index a5f7f3e..c8e3030 100644 > --- a/include/linux/tracepoint.h > +++ b/include/linux/tracepoint.h > @@ -167,10 +167,11 @@ extern void syscall_unregfunc(void); > * structure. Force alignment to the same alignment as the section start. > * > * When lockdep is enabled, we make sure to always do the RCU portions of > - * the tracepoint code, regardless of whether tracing is on or we match the > - * condition. This lets us find RCU issues triggered with tracepoints even > - * when this tracepoint is off. This code has no purpose other than poking > - * RCU a bit. > + * the tracepoint code, regardless of whether tracing is on. However, > + * don't check if the condition is false, due to interaction with idle > + * instrumentation. This lets us find RCU issues triggered with tracepoints > + * even when this tracepoint is off. This code has no purpose other than > + * poking RCU a bit. > */ > #define __DECLARE_TRACE(name, proto, args, cond, data_proto, data_args) \ > extern struct tracepoint __tracepoint_##name; \