From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849AbbKBUZB (ORCPT ); Mon, 2 Nov 2015 15:25:01 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34902 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbbKBUY7 (ORCPT ); Mon, 2 Nov 2015 15:24:59 -0500 Date: Mon, 2 Nov 2015 21:24:55 +0100 From: Michal Hocko To: Dave Jones Cc: David Rientjes , Hongjie Fang =?utf-8?B?KOaWuea0quadsCk=?= , "Eric W. Biederman" , "linux-kernel@vger.kernel.org" Subject: Re: =?utf-8?B?562U5aSNOiBbUEFUQ0h2?= =?utf-8?Q?2?= 4.3-rc6] proc: fix convert from oom_score_adj to oom_adj Message-ID: <20151102202454.GC30736@dhcp22.suse.cz> References: <1f80189385e540c2a5b2747a7a265d8c@SHMBX01.spreadtrum.com> <5eff586de266418090f792077fcff993@SHMBX01.spreadtrum.com> <20151029170422.GH23598@dhcp22.suse.cz> <20151030125903.GD23627@dhcp22.suse.cz> <20151030144643.GE23627@dhcp22.suse.cz> <20151102171850.GA4258@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151102171850.GA4258@codemonkey.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 02-11-15 12:18:50, Dave Jones wrote: > On Sat, Oct 31, 2015 at 09:38:31PM -0700, David Rientjes wrote: > > On Fri, 30 Oct 2015, Michal Hocko wrote: > > > > > > I will hunt for other projects still using the deprecated > > > > file exclusively. Hopefully there won't be too many of them. > > > > > > It doesn't look that bad afterall: > > > $ curl -s http://codesearch.debian.net/results/7223e657af3f2ad0/packages.json > > > {"Packages":["tgt","ggobi","hurd","linux","condor","wine-gecko-2.21","android-platform-frameworks-native","nautilus","procps","wireshark","intel-gpu-tools","iceweasel","icedove","ardour","linux-tools","kde4libs","nss-pam-ldapd","chromium-browser","passenger","archipel-agent-virtualmachine-oomkiller","bleachbit","tilestache","slurm-llnl","ns3","nbd","open-iscsi","mhwaveedit","nilfs-tools","stress-ng","lvm2","gradm2","audit","postgresql-common","zfs-fuse","ocfs2-tools","gimp","advene","lldpad","reniced","pitivi","trinity","petri-foo","rtai","postgresql-9.4","procenv","multipath-tools","percona-toolkit","apparmor","upstart","watchdog","boinc","fusil","util-vserver","booth","geeqie","openssh","oar","android-platform-system-core","kinit","xournal","player","gimp-gap","android-tools"]} > >> > > I did the same type of searching and fixing back then for things like > > udev, chromium, openssh, etc to convert them to oom_score_adj. It was > > mostly trivial because people either set it to -17 to disable from the oom > > killer or to 0 to nullify an oom-disabled process. > > > > I'd love to be able to remove oom_adj. I'm not sure if we can get to that > > point if the instance is that "all userspace" must not write to it and it > > would require users to rebuild their binaries. If we could show that all > > the major open source users of oom_adj (there can't be _that_ many that > > would be significantly impacted since you needed CAP_SYS_RESOURCE to > > reduce it) were converted, maybe Linus would accept it. > > FWIW, you can probably remove trinity from that list. > It only uses oom_adj as "don't write to this file if it exists". Yeah, I have filtered it like many others for exactly this reason -- Michal Hocko SUSE Labs