From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755442AbbKCQej (ORCPT ); Tue, 3 Nov 2015 11:34:39 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:45239 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753138AbbKCQei (ORCPT ); Tue, 3 Nov 2015 11:34:38 -0500 Date: Tue, 03 Nov 2015 11:34:32 -0500 (EST) Message-Id: <20151103.113432.1400073533179795014.davem@davemloft.net> To: arnd@arndb.de Cc: m.grzeschik@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arcnet/com20020: add LEDS_CLASS dependency From: David Miller In-Reply-To: <10338405.rWTFsWuIBE@wuerfel> References: <10338405.rWTFsWuIBE@wuerfel> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Nov 2015 08:34:37 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 03 Nov 2015 14:51:29 +0100 > The newly added led trigger support in the com20020-pci driver causes > build errors when CONFIG_LEDS_CLASS is disabled: > > drivers/built-in.o: In function `com20020pci_probe': > (.text+0x185dc4): undefined reference to `devm_led_classdev_register' > (.text+0x185dd8): undefined reference to `devm_led_classdev_register' > > This adds a Kconfig dependency to prevent the invalid configurations. > Other drivers appear to be split 50:50 between 'select' and 'depends on' > for this symbol, I picked 'depends on' as I could not find a common > policy and it generally causes fewer problems. > > Signed-off-by: Arnd Bergmann > Fixes: 8890624a4e8c ("arcnet: com20020-pci: add led trigger support") Applied.