From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>
Subject: Re: [RFC/PATCH 0/4] perf report: Support folded callchain output (v2)
Date: Tue, 3 Nov 2015 10:35:35 +0900 [thread overview]
Message-ID: <20151103013535.GD11498@danjae.kornet> (raw)
In-Reply-To: <20151103004647.GE21609@kernel.org>
On Mon, Nov 02, 2015 at 09:46:47PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 03, 2015 at 08:46:06AM +0900, Namhyung Kim escreveu:
> > On Mon, Nov 02, 2015 at 08:04:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > > I still think that this is a 'perf report' thing, but one that is
> > > centered in callchains, and that is to be consumed by scripts, not
> > > humans.
>
> > Agreed.
>
> > I'm just looking for a way to support it with minimal change. :)
>
> Hey, me too. A --no-hists flag looks like a quickie, no need to isolate
> callchain code, or anything like that, just one long option switch and
> we get what we need.
Hmm.. okay. Let me think about the --no-hists flags then.
What do you want to do if the --no-hists flags is used without folded
callchain mode or other than --stdio?
And if you want to print other info in the callchains, what would be
the output of non-folded mode?
I think the simplest solution would be supporting the folded mode only
and error out other cases. Is it ok to you?
Thanks,
Namhyung
next prev parent reply other threads:[~2015-11-03 1:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 12:57 Namhyung Kim
2015-11-02 12:57 ` [RFC/PATCH v2 1/4] perf report: Support folded callchain mode on --stdio Namhyung Kim
2015-11-02 12:57 ` [RFC/PATCH v2 2/4] perf callchain: Abstract callchain print function Namhyung Kim
2015-11-02 12:57 ` [RFC/PATCH v2 3/4] perf callchain: Add count fields to struct callchain_node Namhyung Kim
2015-11-02 12:57 ` [RFC/PATCH v2 4/4] perf report: Add callchain value option Namhyung Kim
2015-11-02 20:37 ` [RFC/PATCH 0/4] perf report: Support folded callchain output (v2) Brendan Gregg
2015-11-02 21:30 ` Arnaldo Carvalho de Melo
2015-11-02 22:12 ` Namhyung Kim
2015-11-02 22:28 ` Arnaldo Carvalho de Melo
2015-11-02 22:49 ` Namhyung Kim
2015-11-02 23:04 ` Arnaldo Carvalho de Melo
2015-11-02 23:46 ` Namhyung Kim
2015-11-03 0:46 ` Arnaldo Carvalho de Melo
2015-11-03 1:35 ` Namhyung Kim [this message]
2015-11-03 1:46 ` Arnaldo Carvalho de Melo
2015-11-03 3:17 ` Namhyung Kim
2015-11-02 22:43 ` Brendan Gregg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103013535.GD11498@danjae.kornet \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=brendan.d.gregg@gmail.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®