From: Mark Brown <broonie@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: MMC/regulator boot hang in -next
Date: Tue, 3 Nov 2015 05:35:55 +0000 [thread overview]
Message-ID: <20151103053555.GM20228@sirena.org.uk> (raw)
In-Reply-To: <CALAqxLUTf=WkfRsn7iHxDYdx5TkL4Oun3+LsFubKXzo92=Vo_g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Mon, Nov 02, 2015 at 03:04:29PM -0800, John Stultz wrote:
> On Mon, Nov 2, 2015 at 2:58 PM, Mark Brown <broonie@kernel.org> wrote:
> > No, the internal get voltage call shouldn't be locking in the first
> > place (and indeed it doesn't do so AFAICT?).
> } else if (rdev->supply) {
> ret = regulator_get_voltage(rdev->supply); <-----
> } else {
> Where _regulator_get_voltage() is called from
> regulator_set_voltage_unlocked(), called from regulator_set_voltage().
>
Well, that's the issue then - get_voltage() needs to be locking the
supplies like set_voltage() does.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-03 5:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 19:57 John Stultz
2015-11-02 20:46 ` Bjorn Andersson
2015-11-02 20:50 ` John Stultz
2015-11-02 22:03 ` John Stultz
2015-11-02 22:27 ` John Stultz
2015-11-02 22:58 ` Mark Brown
2015-11-02 23:04 ` John Stultz
2015-11-03 5:35 ` Mark Brown [this message]
2015-11-02 21:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103053555.GM20228@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®