From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbbKCHlz (ORCPT ); Tue, 3 Nov 2015 02:41:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48915 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbbKCHlw (ORCPT ); Tue, 3 Nov 2015 02:41:52 -0500 Date: Tue, 3 Nov 2015 08:41:48 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Mohit Agrawal Subject: Re: [PATCH] perf sched latency: Fix removed thread issue Message-ID: <20151103074148.GC23878@krava.brq.redhat.com> References: <1446462625-15807-1-git-send-email-jolsa@kernel.org> <20151102225353.GC21609@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151102225353.GC21609@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2015 at 07:53:53PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 02, 2015 at 12:10:25PM +0100, Jiri Olsa escreveu: > > If machine's thread gets excited (EXIT event is received), > > we set thread->dead = true and it is later on removed from > > machine's tree if the pid is reused on new thread. > > > The latency subcommand holds tree of working atoms sorted > > by thread's pid/tid. If there's new thread with same pid > > Humm, wher is the latency subcommand handling the EXIT event? > > I see: > > perf_sched__lat > perf_sched__read_events > session = perf_session__new(&file, false, &sched->tool); > perf_session__process_events(session) > > And sched->tool->exit() is not set, which will make > perf_session__process_events(), when calling perf_tool__fill_defaults() > set it to process_event_stub() which will do nothing for > PERF_RECORD_EXIT events, no? yep, latency command does not handle EXIT event, but the thread is removed via FORK event.. the first changelog paragraph might be a little misleading sorry ;-) could you please change it to: --- If machine's thread gets excited (EXIT event is received), we set thread->dead = true and it is later on removed from machine's tree if the pid is reused on new thread. We dont handle EXIT command in 'perf sched latency', however the old thread is removed anyway when FORK event is received for new thrad with same pid/tid. --- thanks, jirka