From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755010AbbKCInP (ORCPT ); Tue, 3 Nov 2015 03:43:15 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33182 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbbKCInN (ORCPT ); Tue, 3 Nov 2015 03:43:13 -0500 Date: Tue, 3 Nov 2015 17:43:01 +0900 From: Namhyung Kim To: Tom Zanussi Cc: rostedt@goodmis.org, daniel.wagner@bmw-carit.de, masami.hiramatsu.pt@hitachi.com, josh@joshtriplett.org, andi@firstfloor.org, mathieu.desnoyers@efficios.com, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 14/28] tracing: Add hist trigger support for clearing a trace Message-ID: <20151103084301.GB20951@danjae.kornet> References: <48a0ac9399d67006e88b2f3d8ab5c457bc8b989c.1445530672.git.tom.zanussi@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <48a0ac9399d67006e88b2f3d8ab5c457bc8b989c.1445530672.git.tom.zanussi@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2015 at 01:14:18PM -0500, Tom Zanussi wrote: > Allow users to append 'clear' to an existing trigger in order to have > the hash table cleared. Same as the previous comment: It'd be better not creating a new hist if given hist doesn't exist. Thanks, Namhyung > > This expands the hist trigger syntax from this: > # echo hist:keys=xxx:vals=yyy:sort=zzz.descending:pause/cont \ > [ if filter] > event/trigger > > to this: > > # echo hist:keys=xxx:vals=yyy:sort=zzz.descending:pause/cont/clear \ > [ if filter] > event/trigger > > Signed-off-by: Tom Zanussi > Tested-by: Masami Hiramatsu >