From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508AbbKCQbk (ORCPT ); Tue, 3 Nov 2015 11:31:40 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46199 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbbKCQbi (ORCPT ); Tue, 3 Nov 2015 11:31:38 -0500 Date: Tue, 3 Nov 2015 16:31:17 +0000 From: Mark Brown To: "Andrew F. Davis" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Linus Walleij , Alexandre Courbot , Samuel Ortiz , Lee Jones , Liam Girdwood , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20151103163117.GQ20228@sirena.org.uk> References: <1446244904-29315-1-git-send-email-afd@ti.com> <1446244904-29315-6-git-send-email-afd@ti.com> <20151101023735.GE28319@sirena.org.uk> <5638D97A.8040306@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nWEzmRaGLXxZdI3i" Content-Disposition: inline In-Reply-To: <5638D97A.8040306@ti.com> X-Cookie: Even bytes get lonely for a little bit. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 5/6] regulator: tps65086: Add regulator driver for the TPS65086 PMIC X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nWEzmRaGLXxZdI3i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 03, 2015 at 09:57:46AM -0600, Andrew F. Davis wrote: > On 10/31/2015 09:37 PM, Mark Brown wrote: > >On Fri, Oct 30, 2015 at 05:41:43PM -0500, Andrew F. Davis wrote: > >>+ struct regulator_desc desc; > >>+ unsigned int decay_reg; > >>+ unsigned int decay_mask; > >The decay_reg and decay_mask fields appear to be entirely write only, > >why are they present? > Not sure what you mean, they are written to differently for each regulator, > and read when setting the decay mode in _probe. Ugh, that's a bit hidden (mostly due to not using the callback). > >>+ ret = of_regulator_match(&pdev->dev, pdev->dev.of_node, > >>+ tps65086_matches, > >>+ ARRAY_SIZE(tps65086_matches)); > >>+ if (ret < 0) { > >>+ dev_err(tps->dev, "Error parsing regulator init data\n"); > >>+ return ret; > >>+ } > >Please match regulators using the fields in the regulator_desc rather > >than open coding. > I need to match to get the driver specific information for each regulator, > if I let regulator_register do it I never get a chance to process the match, > unless there is a callback or something I'm missing. There's a callback you are missing, of_parse_cb(). --nWEzmRaGLXxZdI3i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWOOFUAAoJECTWi3JdVIfQL+gH/1gamFD4yXMhl9M/GVBcJSXt Sg0QAwkqCwb2LwCSrHz/0gc3w9qbOlcLP91npZh9kVk4b+LpitmjiDq2osX/SEOf EBAmD19qb+M/Zl2aKcPPap5/CB7Xarvxz0zKCezYVEPv6l6xTHl9IUbyOkuML5kK yle1bqWL07w/sbIZHFfYNG11AZgp+qbCq1iwKPMPVlOx9Mk84AyE9i/3oPxJjYwG PQKnew7PoWbF6p272x9xY+1qHsNRcpOKLYekpidE0mFTY7NKgOI9mDlm2qZfAtus 0grs4jiwRG6aL16xZ6lDgiYC4RnYtQdVVoAd21jXxnrWzMdRyY/ZDzCyEbLFyPY= =2JKT -----END PGP SIGNATURE----- --nWEzmRaGLXxZdI3i--