From: Mark Brown <broonie@kernel.org>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH v2] regulator: of: removing two variables min_uV and max_uV
Date: Tue, 3 Nov 2015 17:29:11 +0000 [thread overview]
Message-ID: <20151103172910.GR20228@sirena.org.uk> (raw)
In-Reply-To: <1446457680-21318-1-git-send-email-saurabh.truth@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Mon, Nov 02, 2015 at 03:18:00PM +0530, Saurabh Sengar wrote:
> replacing the of_get_property function with of_property_read_u32 function
> as its help removing two variables.
> I have put these check back, please let me know if this v2 patch is worth
It's a bit marginal TBH and...
> /* Only one voltage? Then make sure it's set. */
> - if (min_uV && max_uV && constraints->min_uV == constraints->max_uV)
> + if (constraints->min_uV && constraints->max_uV
> + && constraints->min_uV == constraints->max_uV)
> constraints->apply_uV = true;
...this does disallow a constraint of 0-XuV which was previously legal
and potentially meaningful. Hrm.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-11-03 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 15:01 [PATCH] " Saurabh Sengar
2015-11-01 2:29 ` Mark Brown
2015-11-02 9:48 ` [PATCH v2] " Saurabh Sengar
2015-11-03 17:29 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103172910.GR20228@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®