From: David Miller <davem@davemloft.net>
To: stefanha@redhat.com
Cc: netdev@vger.kernel.org, thellstrom@vmware.com,
asarwade@vmware.com, jhansen@vmware.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VSOCK: call sk->sk_data_ready() on accept()
Date: Wed, 04 Nov 2015 22:03:32 -0500 (EST) [thread overview]
Message-ID: <20151104.220332.1882923396348027768.davem@davemloft.net> (raw)
In-Reply-To: <1446641922-32243-1-git-send-email-stefanha@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Wed, 4 Nov 2015 12:58:42 +0000
> When a listen socket enqueues a connection for userspace to accept(),
> the sk->sk_data_ready() callback should be invoked. In-kernel socket
> users rely on this callback to detect when incoming connections are
> available.
>
> Currently the sk->sk_state_change() callback is invoked by
> vmci_transport.c. This happens to work for userspace applications since
> sk->sk_state_change = sock_def_wakeup() and sk->sk_data_ready =
> sock_def_readable() both wake up the accept() waiter. In-kernel socket
> users, on the other hand, fail to detect incoming connections.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Applied.
prev parent reply other threads:[~2015-11-05 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 12:58 Stefan Hajnoczi
2015-11-05 3:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104.220332.1882923396348027768.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=asarwade@vmware.com \
--cc=jhansen@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®