From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932413AbbKDIs7 (ORCPT ); Wed, 4 Nov 2015 03:48:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54966 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbKDIs5 (ORCPT ); Wed, 4 Nov 2015 03:48:57 -0500 Date: Wed, 4 Nov 2015 09:48:54 +0100 From: Jiri Olsa To: Andi Kleen Cc: jolsa@kernel.org, acme@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout Message-ID: <20151104084854.GG29671@krava.brq.redhat.com> References: <1446515428-7450-1-git-send-email-andi@firstfloor.org> <1446515428-7450-6-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446515428-7450-6-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2015 at 05:50:24PM -0800, Andi Kleen wrote: SNIP > @@ -729,32 +722,8 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix) > if (prefix) > fprintf(output, "%s", prefix); > > - if (scaled == -1 || !counter->supported) { > - fprintf(output, "%*s%s", > - csv_output ? 0 : 18, > - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED, > - csv_sep); > - fprintf(output, "%-*s%s", > - csv_output ? 0 : unit_width, > - counter->unit, csv_sep); > - fprintf(output, "%*s", > - csv_output ? 0 : -25, > - perf_evsel__name(counter)); so this changed current 'not supported' output: stalled-cycles-frontend stalled-cycles-backend into 0 stalled-cycles-frontend 0 stalled-cycles-backend # 0.00% backend cycles idle > - > - if (counter->cgrp) > - fprintf(output, "%s%s", csv_sep, counter->cgrp->name); haven't tried with cgroup, but I think that removing above hunk will not do any good to it.. jirka > - > - print_running(avg_running, avg_enabled); > - fputc('\n', output); > - return; > - } > - > uval = avg * counter->scale; > - printout(-1, 0, counter, uval, prefix); > - SNIP