From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbbKET0Y (ORCPT ); Thu, 5 Nov 2015 14:26:24 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:38027 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbbKET0X (ORCPT ); Thu, 5 Nov 2015 14:26:23 -0500 Date: Thu, 05 Nov 2015 14:26:19 -0500 (EST) Message-Id: <20151105.142619.983467860147585345.davem@davemloft.net> To: Julia.Lawall@lip6.fr Cc: kernel-janitors@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, roopa@cumulusnetworks.com, rshearma@brocade.com, ebiederm@xmission.com Subject: Re: [PATCH] decnet: remove macro-local declarations From: David Miller In-Reply-To: <1446718696-32505-1-git-send-email-Julia.Lawall@lip6.fr> References: <1446718696-32505-1-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Nov 2015 11:26:22 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Date: Thu, 5 Nov 2015 11:18:16 +0100 > Move the variable declarations from the for_nexthops macro to the > surrounding context, so that it is clear where these variables are > declared. This also makes it possible to remove the endfor_nexthops macro. > > This change adds new arguments to the macro for_nexthops. They are ordered > such that a pointer to the referenced object comes first, the index in the > list comes next, and the list itself comes last, roughly in analogy with > the list_for_each macros. > > Signed-off-by: Julia Lawall > > --- > > This patch takes care of a single file, where the macros are defined > locally. If the basic transformation looks OK, I will change the other > files that either likewise define their own macros or use the macros in > net/mpls/internal.h. The potentially affected files are: ... This looks fine to me. Please resubmit this when net-next opens back up, which should be shortly after -rc1. Thanks.