From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033791AbbKEHCY (ORCPT ); Thu, 5 Nov 2015 02:02:24 -0500 Received: from mail-bl2on0072.outbound.protection.outlook.com ([65.55.169.72]:60288 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1033774AbbKEHCR (ORCPT ); Thu, 5 Nov 2015 02:02:17 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; socionext.com; dkim=none (message not signed) header.d=none;socionext.com; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Wed, 4 Nov 2015 23:02:00 -0800 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Masahiro Yamada CC: , Philipp Zabel , Michal Simek , Chen-Yu Tsai , "Maxime Ripard" , Subject: Re: [PATCH] reset: check return value of reset_controller_register() Message-ID: <20151105070200.GV6436@xsjsorenbubuntu> References: <1446702896-1156-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446702896-1156-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21920.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD034;1:dLoTNuTV7EZctxwQ79QT9BqfkEECuISAAJnsFr33Gn/mUsC4DFs7g8RrLhecM6pa6lnPL+YC9rpzpmRBr4HngUnosnibG8COQRkp5mMI8HiqJ2Z8JSUTmkNoOLofjM9KJDBG4sX/6gkFDo+mSpxQUd0vqsjAG8J5YyDIGhnXkaneIsF67S4gGhXIw5f5Y0LQjSNqkTbEVh88Gr2Ei7yKqcL4U8Rabg8gKWc2OkhlV9CfVU6leEtqgyWaGQWb7pQ+bFnQDMu2LGBWED0gFbODEXrPRx8/41edrJnytbKeiDaHDkUeK874X+Epk7IO/6LHkRpTfboJHuJwlPaoEru+8x7SHlrWXsD9c088I9OmvUq6BmpbGdSADAq4W6yNdmz4 X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(377424004)(199003)(189002)(86362001)(57986006)(47776003)(5001960100002)(33656002)(110136002)(189998001)(19580405001)(558084003)(33716001)(5008740100001)(54356999)(50986999)(23676002)(19580395003)(36386004)(85182001)(92566002)(5007970100001)(76176999)(50466002)(16796002)(85202003)(11100500001)(76506005)(4001350100001)(87936001)(77096005)(2950100001)(106466001)(63266004)(83506001)(81156007)(6806005)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB038;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB038;2:9B7n0QVNJMCbjsrwiBhQd7K6GCHOCe/WZ/TkrSsSywQLfyCC3kXNFwUYLQmiKSU5+VsuamUYDyylUld+3KU4tZFBnzlGbor6CKFGeg8haRppPPe7URayie0UMqZwcyhGnlLwq3w5yv2EcUx/+cJ3aBlbIjBtdSK+EPMoOfdHO3U=;3:XrZ81VxLqEV4avPDX36p8h/crYEbFn749ik4O7osB2E68YDWvCo6a6SVtOZoU/X4N6YDD6oD22JktZvQR5LddcW0GxhAmPeeTmwJfJtaj20O0RtqbbYQXMEOutUHiUzr9oVb6weLeQXnebd4dQRnA8C/g27WcboAxriNXnKVJ0WKTmQEno2XVZJDRLhVneUqET/NOrclHJ+kEYoVRjtzNFOd5l1lYdi59azRV+ZboYOi7AQIx7UxExwkqjYqe1HR8f3VkD/GO2LT4T3AsrIg4w==;25:9D/jyNe9g9aVLYVcwi9a3/bclPPDysEplAkWtiqYVYWlhOtrk2Cm/fm2HQn1oXXNme9OnXEm3WGvoxPVz4USlzEQQhI5iOpZTJ9vuihFy64pzZVqa/WSKflynbfFfPeZVeGBFYCronxmTdWhigGAFOalsvfhLJ3wwV3S3Gbt7BgaTAGB2MHzV3Hmh+UsBaneaWyEqNYxzvlR4MwTdQ7XwTpmcsBCkp2laFltMn0eQ9EwfiELvhPk0zl5vwBawsDX X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BY2FFO11HUB038; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB038;20:8Sl2McNsStvEd6IqagiklnGCJPVhMs3rCs1XKPPqZ4fWNe9jHw0gIypnI0qPN/sizJ2Vc5b2rxFiN0QU4f0fhGJwcQYHoCKXUT7drYkH0OUK+2YhLdpTUm648APFzrzW55pVlRq5aq2Yz/xhELF8AL10zxRhv7DXirfs+LrbF/vRciAsxvbSo+0QlXDgw6t8VMMaQOX+CajcCmkBElUUowC96r7ugyRRVL4YenZAwn4acyX9R4Y9jT5KTmBU6u8b+NdIDvbbpmzNcMs+fdq/rTJ2MawbBc3bTkFHPU7sdG/wLZT+u6muopYDWQhZ8Z4zXKEpXE4F75SEbDERuxfV7ASzRIFxV7XHK2hxXdi8qSJcvt38ajETs8tP4AGb0M/KeN6REByuU6jseyMuE5/ABboquyVd4E9KcqwD1Hmshq0Eet4C4MIMXqWf+oQduIKN8XJU9mEZkmXiZq1eE+0ue+AsG7nVr5s8Xl/JY/crl3aY9FOBrBqE8O3T1QEri5KS;4:M9yYqKRkg0R1scjODU6svIvpJW/XHpVGKJOv8fGr0fM+T81XaQoTGAgdtqK9mh2FsXcoEhIY3yHaW8VNyfi8iui0PVFpvmV2DhmYQjrHhwHFwPjv/NkKHKNBojQSR2/vh62LylRb7EtdrPUtB0k51CLxBJYf6tJFrhOEjrBuBn/xEGHzLxeju59hYAYfEc7IAe6Praos89NftImRVrTMowW8nY6MJjbNoMcVNPUrOqZ5ChqLAJSMhy3gJ3AvrLsvdSBdv0NsFMM/TR9PIdbfIAPfA+czwLg+PfuXZ010G20TKeT5u1W1nWErbGW9OqMB0h7DGQ/OJ4fgcf/oubx513VXKR5oMe0ePBdBNME2D3HmCSoSzux9NMVgmyZOTa/X X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046);SRVR:BY2FFO11HUB038;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB038; X-Forefront-PRVS: 0751474A44 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJGRk8xMUhVQjAzODsyMzpkcmhOTURiYzk3TGFpSVJ3TkloTmp5cGgw?= =?utf-8?B?RXE5UXdaVW5kYXYvV2FnNGFQM2xPOHN1SldYMk5MdEpUQjhDU3pNc0RWUUEz?= =?utf-8?B?eEltblZrVm53RHV2Z1hPWm4ybTd3ZytVSFJaWXB2Um14L0dZV3dVM3pGMHgw?= =?utf-8?B?QUoyUkU3emNOZlVlR1NkL0YzNVJJZUJlMXpRajhSb2VnRExtR0VxQVdsTFND?= =?utf-8?B?b1I1VC9adldqRjhCWDB3aFZNWDlhZ05XMFZQS0lJckdld3k2MFpQK2hpNWw5?= =?utf-8?B?OUVhZDF0dXhXSXNNWU1zVFh6ZmQ0aFRiNm15b294SWVQQTBCSU5ZM21YYjlS?= =?utf-8?B?OUhucXl2dDFoclpwQ2ZDWk1waW81OU5ZK05SRWVva2FZZThjL1E4R1pMQjlZ?= =?utf-8?B?UlVheVBMbkFndzI5ak80dnNQS1BReEVzc3BNRHR0elRNQVF4V2FUUStWaGFU?= =?utf-8?B?dW55Y0o4YVk0aTMyc2hxdnFkOHZjbWdiZ2lTQlJyMkk3MTdQU0ZpMkh6dFNj?= =?utf-8?B?ZWs5MUE0Tkp3MHFjTm91dTBiQTFLRzF3allrRUlPclU5c1BsbThBZzhnYkZY?= =?utf-8?B?YWFBUTQ2eFFDNHVNUytLanZGL0FBUEEvTWV1SXlGejF4TzZXUHJjR0V6UjR5?= =?utf-8?B?SXljUFhEYlJYWHFBRkJsOXBqVXpWejRxQk55eVE2MXA1Nm1ISXpJc0FPc1ll?= =?utf-8?B?T1pxU3FpdEJsMElGRGJHL3kreGVxZldCT2VoRzZ2YU12MmlFYmplUjZsZU9W?= =?utf-8?B?VHRkOXJnYzN3bW9UZytzbHlLQ1pkUXA5aE90bGtaZ1R3NXRXQ0xUSEtxRkJy?= =?utf-8?B?K01zc1F1WnJlcmJKeGVTNThPWlMrc2FqQitKdC9lUnNnczNEOEFKdFlMcVFy?= =?utf-8?B?YmI3QXJZekJaaWRoNDFBclIyOHlhcFE4N3BOdUpyeGM3ZW96UWVZd09wbURp?= =?utf-8?B?c2s2NWFTM0tvQlh3N21tNTRyY1RaUmFWZ1JpVjZXWVBXVEQ4SUR6TWJCNUZE?= =?utf-8?B?TVM2N2YvQUZzaEJybFBVU3RRUUZDMFEraWFWN1p0RVI1QnVySXpOUSs3V3V2?= =?utf-8?B?cUtiSjF2eUZOejh2RFpWeENzWDVSRFZ3QXNwMHkxUzJUNzdUU0pRQldkWUIv?= =?utf-8?B?cldFWlpIM1ROSFZwL0hFR2hTcG8yWGVmZWZUN1FwRGVDdTdzQURKeGN2ODho?= =?utf-8?B?U0FoZmhZWm1IQm1laGs4bFJwMkNLamt3alQ2VCtqYWtvakkxRXI1bncyTFlh?= =?utf-8?B?NlE2T1JrUXRLaytmSDg4VTBHRDJrdFVVbWNob1ZPRGgvYlI2anNkc3VBc3ht?= =?utf-8?B?UFp1VlpTRVFIVFVybVRtYU5DTWovMFloekgrWkxtM29HSTVTQ1ZQblhwVjRq?= =?utf-8?B?U1p4RnJFblE3ZWE2bFVxK0JoZ1RaNEU4c2JjbkRvVUQ0aGxwSFRrTWNaT1No?= =?utf-8?B?OGhaYjFsc1NIYUV0TFl1aVAreG9QcXVFT1dxaHBSeU9EV1I1UFF0aGVPZzFH?= =?utf-8?B?cGNLNFMzTGE3cXhxMHd5OWo5QU04QmM4cEIxL0g0bjJQWVhBNTJPYml4ZmVZ?= =?utf-8?B?M1BGUlNkZWdMRm1QMkNvbktrbWpWeEtBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB038;5:fiMto45aMXob3A4f8J1KN0cS/W5rf53gRORVcAUGmsRzdNRjlZIHK/faicUXcYsFGZ1tm0H80fhcedAZL7xb56K4BpuRJmx4K6Q9amzVY/M40PZ0CdegVqOvBISCX2wAesRE0e3An7eVuSp+oYzYzw==;24:vRuMbcU6EvEwIJt0ceIHOfT5vJNqfrN/yLH31WFE6KFvk0wL5kDMddp0BoKLPKqIVLU5igAmHYz0YhtzzFbN+3kDjGAXKpPBjTOk2cpBZl8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2015 07:02:14.5666 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2FFO11HUB038 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-11-05 at 02:54PM +0900, Masahiro Yamada wrote: > Currently, reset_controller_register() always return 0, but it would > be better to check its return code. > > Signed-off-by: Masahiro Yamada Acked-by: Sören Brinkmann Sören