From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032734AbbKEMUw (ORCPT ); Thu, 5 Nov 2015 07:20:52 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48298 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032457AbbKEMUt (ORCPT ); Thu, 5 Nov 2015 07:20:49 -0500 Date: Thu, 5 Nov 2015 12:20:38 +0000 From: Mark Brown To: Masahiro Yamada Cc: Linux Kernel Mailing List , Philipp Zabel , linux-spi@vger.kernel.org Message-ID: <20151105122038.GF18409@sirena.org.uk> References: <1446722128-11961-1-git-send-email-yamada.masahiro@socionext.com> <1446722128-11961-3-git-send-email-yamada.masahiro@socionext.com> <20151105112847.GA18409@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ExXT7PjY8AI4Hyfa" Content-Disposition: inline In-Reply-To: X-Cookie: Put your trust in those who are worthy. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 92.40.249.56 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ExXT7PjY8AI4Hyfa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote: > 2015-11-05 20:28 GMT+09:00 Mark Brown : > > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as > > ARCH_SUNXI. > The compile test of this driver should pass even if RESET_CONTROLLER > is not defined. > So, it does not matter for COMPILE_TEST. If that is the case then the change here is that the dependency on RESET_CONTROLLER is just redundant which isn't what the commit message says. --ExXT7PjY8AI4Hyfa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWO0mVAAoJECTWi3JdVIfQVV4H/iD5pEg47Ci+GA6Fle6pxJvL HQrZt+ShlDYm/jZHw+oJ/+uaVWmIMUr6Ccr0L3ZJvo6OX78/TY3BWIcWbI4J5yfb EeVqr/Wzj5y6IFhh2PycAh8+pH9WRwQmYao8WD+gl2XhfMq4U95GMZCDdfdTXNNv TyJ05sG7DCo71dhZQxEPFmTC79/zphtrOjKbCGrfwXQfi+dzAd8OX/3Sm1v6mWII ImPXNodCnTiA3NQyn0jJejW4lbRGdMZnuHF/d1BasP56r/GdXhcxJ5uLG/OIudxL aLsWFHUkf9k6dJXarXJgA3Rpiq/88nOYSUub0Rd90ribYNYDN+h6i+FwLeJS5K8= =V8Qs -----END PGP SIGNATURE----- --ExXT7PjY8AI4Hyfa--